[libvirt] [PATCH v2] qemuBuildMemPathStr: Forbid memoryBacking/access for non-numa case

[Ján Tomko]

On Wed, Jan 03, 2018 at 07:06:01AM +0100, Michal Privoznik wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1448149
>
>If a domain has no numa nodes, that means we don't put any
>memory-backend-file onto the qemu command line. That in turn
>means we can't set access='shared'. Therefore, we should produce
>an error instead of ignoring the setting silently.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
>
>diff to v2:
>- switched from check at cmd line generation to validation callback (as
>  requested in review).
>
> src/qemu/qemu_domain.c                          | 29 ++++++++-
> tests/qemuxml2argvdata/hugepages-memaccess3.xml | 87 +++++++++++++++++++++++++
> tests/qemuxml2argvtest.c                        |  3 +
> 3 files changed, 118 insertions(+), 1 deletion(-)
> create mode 100644 tests/qemuxml2argvdata/hugepages-memaccess3.xml
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180103/28bab46e/attachment-0001.sig>