[libvirt] [PATCH 2/5] util: introduce virHostCPUGetMicrocodeVersion

Ján Tomko jtomko at redhat.com
Thu Jan 4 15:42:04 UTC 2018

On Thu, Jan 04, 2018 at 04:27:45PM +0100, Jiri Denemark wrote:
>On Thu, Jan 04, 2018 at 16:15:46 +0100, Peter Krempa wrote:
>> On Thu, Jan 04, 2018 at 15:58:09 +0100, Jiri Denemark wrote:
>> > +        char ebuf[1024];
>> > +        VIR_DEBUG("Failed to read microcode version from %s: %s",
>> > +                  CPUINFO_PATH, virStrerror(errno, ebuf, sizeof(ebuf)));
>> Formatting the error message into a debug message does not make much
>> sense. I'd just log 'errno' in raw since this function does not really
>> return any errors.
>> ACK with pointless error formatting removed.
>It's not pointless. It makes the log useful without having to look at
>/usr/include/asm-generic/errno-base.h. And it will only be done once in
>libvirtd lifetime so it's not really wasting CPU cycles or something.

ACK including the error formatting. I see the point in it, CPU cycles
are cheaper than human cycles.


>libvir-list mailing list
>libvir-list at redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180104/f82d43e6/attachment-0001.sig>

More information about the libvir-list mailing list