[libvirt] [PATCH] qemuDomainAttachDeviceMknodHelper: Remove symlink before creating it

[Andrea Bolognani]

On Fri, 2018-01-05 at 14:38 +0100, Michal Privoznik wrote:
> > However, later on:
> > 
> > > > +            virReportSystemError(errno,
> > > > +                                 _("Unable to create symlink %s"),
> > > > +                                 data->target);
> > > > +            goto cleanup;
> > 
> > You should use data->file here to be consistent.
> 
> How about:
> 
> _("Unable to create symlink %s -> %s"), data->target, data->file
> 
> Here and above.

Yeah, I thought about that too after sending the mail :)

I would go for a more explicit wording, though:

  _("Unable to create symlink %s (pointing to %s)"),
  data->file, data->target

or something along the lines.

-- 
Andrea Bolognani / Red Hat / Virtualization