[libvirt] [PATCH 0/4] Alter Disk Volume logic to use objects

Michal Privoznik mprivozn at redhat.com
Wed Jan 10 09:16:26 UTC 2018


On 01/09/2018 09:05 PM, John Ferlan wrote:
> This series converts the storage volume forward linked list into
> an object that contains hash tables of volume objects.
> 
> The first two patches resolve issues seen during testing with
> the Disk backend which had some special cased code to handle
> the Create/Delete paths and interactions with the partition logic.
> The first patch was much more quickly seen with object free logic
> in place.
> 
> The second two patches make the conversion to objects and hash
> tables in "smaller chunks", but they could easily be combined.
> 
> John Ferlan (4):
>   storage: When delete volume avoid disk backend removal
>   storage: Modify virStorageBackendDiskMakeDataVol logic
>   storage: Introduce _virStorageVolObj[List]
>   storage: Complete implementation volume by hash object
> 
>  src/conf/virstorageobj.c           | 540 ++++++++++++++++++++++++++++++-------
>  src/storage/storage_backend_disk.c |  40 +--
>  src/storage/storage_driver.c       |  14 +-
>  3 files changed, 471 insertions(+), 123 deletions(-)
> 

ACK series, but see my points in 4/4 before pushing please.

Michal




More information about the libvir-list mailing list