[libvirt] [PATCH v2 2/2] tests: sysinfotest: add new test case for S390

[Pino Toscano]

On Friday, 12 January 2018 12:38:02 CET Bjoern Walk wrote:
> Let's add a test case for S390 with CPU frequency information available.
> Test data is sampled from an IBM z13 system running kernel 4.14 on LPAR.
> 
> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
> Signed-off-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
> ---

LGTM, just a couple of notes that came into my mind when reading the
existing sysinfodata for s390.

> diff --git a/tests/sysinfodata/s390-freqcpuinfo.data b/tests/sysinfodata/s390-freqcpuinfo.data
> new file mode 100644
> index 00000000..0edc371d
> --- /dev/null
> +++ b/tests/sysinfodata/s390-freqcpuinfo.data
> [...]
> +processor 0: version = 00,  identification = 145F07,  machine = 2964
> +processor 1: version = 00,  identification = 145F07,  machine = 2964
> +processor 2: version = 00,  identification = 145F07,  machine = 2964
> +processor 3: version = 00,  identification = 145F07,  machine = 2964
> +processor 4: version = 00,  identification = 145F07,  machine = 2964
> +processor 5: version = 00,  identification = 145F07,  machine = 2964
> +processor 6: version = 00,  identification = 145F07,  machine = 2964
> +processor 7: version = 00,  identification = 145F07,  machine = 2964

All the various "identification", and ...

> diff --git a/tests/sysinfodata/s390-freqsysinfo.data b/tests/sysinfodata/s390-freqsysinfo.data
> new file mode 100644
> index 00000000..1941ef0b
> --- /dev/null
> +++ b/tests/sysinfodata/s390-freqsysinfo.data
> @@ -0,0 +1,173 @@
> +Manufacturer:         IBM
> +Type:                 2964
> +Model:                704              NC9
> +Sequence Code:        0000000000085F07

.. this value are replaced by what look like dummy values, so maybe
the same should be done for this data too (in case they are sensitive
information)?

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180112/99f56528/attachment-0001.sig>