[libvirt] [PATCH v2 1/2] util: virsysinfo: parse frequency information on S390

[Bjoern Walk]

Pino Toscano <ptoscano at redhat.com> [2018-01-12, 01:37PM +0100]:
> On Friday, 12 January 2018 12:38:01 CET Bjoern Walk wrote:
> > +    while ((tmp_base = strstr(tmp_base, "cpu number")) &&
> > +           (tmp_base = virSysinfoParseS390Line(tmp_base, "cpu number", &ncpu))) {
> > +        unsigned int n;
> > +        char *mhz = NULL;
> > [...]
> > +        if (n >= ret->nprocessor) {
> > +            VIR_DEBUG("CPU number '%d' out of range", n);
> 
> Since 'n' is unsigned int, then the right printf format is %u.

You are right, of course. Expected to get a compiler warning or
syntax-check error, though.

> The rest of the patch seems good to me.

Thanks.

> 
> Thanks,
> -- 
> Pino Toscano


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 906 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180112/2e8de802/attachment-0001.sig>