[libvirt] [PATCH] qemu: qemuDomainNamespaceUnlinkPaths: Return 0 in case of success

Michal Privoznik mprivozn at redhat.com
Wed Jan 17 16:10:30 UTC 2018


On 01/17/2018 04:47 PM, Marc Hartmayer wrote:
> Commit 7a931a4204af refactored the code and probably forgot to add
> this line.
> 
> Signed-off-by: Marc Hartmayer <mhartmay at linux.vnet.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 5c171e4cbd6c..441bf5935b14 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -10212,7 +10212,7 @@ qemuDomainNamespaceUnlinkPaths(virDomainObjPtr vm,
>              goto cleanup;
>      }
>  
> -
> +    ret = 0;
>   cleanup:
>      virStringListFreeCount(devMountsPath, ndevMountsPath);
>      virObjectUnref(cfg);
> 

Ooops. Yes. ACKed and pushed. Definitely a release material.

Michal




More information about the libvir-list mailing list