[libvirt] [PATCH] Revert "qemu: monitor: do not report error on shutdown"

Ján Tomko jtomko at redhat.com
Fri Jan 19 13:11:32 UTC 2018


On Fri, Jan 19, 2018 at 02:00:44PM +0100, Michal Privoznik wrote:
>This reverts commit aeda1b8c56dc58b0a413acc61bbea938b40499e1.
>
>Problem is that we need mon->lastError to be set because it's
>used all over the place. Also, there's nothing wrong with
>reporting error if one occurred. I mean, if there's a thread
>executing an API and which currently is talking on monitor it
>definitely wants the error reported.
>

Is there a public bugzilla link you could add here?

>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_monitor.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180119/22078742/attachment-0001.sig>


More information about the libvir-list mailing list