[libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

Daniel P. Berrange berrange at redhat.com
Mon Jan 22 12:42:47 UTC 2018

On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote:
> On Mon, Jan 22, 2018 at 12:05:19PM +0000, Daniel P. Berrange wrote:
> > This extends the update hook so that it enforces a requirement to have a
> > Signed-off-by line in every commit message. This can be optionally
> > turned off in individual repos by setting the "hooks.allowmissingsob"
> > git config variable.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> > ---
> > update | 16 +++++++++++++++-
> > 1 file changed, 15 insertions(+), 1 deletion(-)
> > 
> Given that signed-off-by lines are pointless for patches authored and
> committed by the same person,

They are not pointless. They provide an explicit assertion that the author
is acknowledged they are permitted to make the contribution under the project's
license. This is distinct from the Author/Committer info in the commit, because
that is added automatically my git with no thought required by the developer.

> NACK unless the hooks.allowmissingsob will be set in the main
> libvirt.git (I don't really care about other repos).

I'm intending it to be set in *every* repository include libvirt.git. There
is no real world burden for developers to add a signed-off-by line to the
commits they contribute to the project, and it puts us in a stronger legal
position going forward. It is already commonplace across countless open
source projects, including many that we interact & build on in libvirt.

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

More information about the libvir-list mailing list