[libvirt] [PATCH 0/4] Add admin protocol support for virtlogd/virtlockd

[Daniel P. Berrange]

On Mon, Jan 22, 2018 at 04:44:10PM +0100, Michal Privoznik wrote:
> On 01/19/2018 06:09 PM, Daniel P. Berrange wrote:
> > The initial admin protocol support was only integrated into libvirtd.
> > This series extracts that code so that it is reusable with all the
> > daemons we have (and more than we'll get).
> > 
> > Daniel P. Berrange (4):
> >   admin: move admins server impl/dispatch into src/admin directory
> >   util: add virGetUNIXSocketPath helper
> >   logd: add support for admin protocol in virtlogd
> >   lockd: add support for admin protocol in virtlockd
> > 
> >  .gitignore                                         |   1 +
> >  cfg.mk                                             |   3 +-
> >  daemon/Makefile.am                                 |  33 +----
> >  daemon/libvirtd.c                                  |   2 +-
> >  daemon/libvirtd.h                                  |  10 --
> >  po/POTFILES.in                                     |   4 +-
> >  src/Makefile.am                                    |  33 ++++-
> >  {daemon => src/admin}/admin_server.c               |   4 +-
> >  {daemon => src/admin}/admin_server.h               |   6 +-
> >  .../admin.c => src/admin/admin_server_dispatch.c   |  21 ++--
> >  .../admin.h => src/admin/admin_server_dispatch.h   |   9 +-
> >  src/libvirt-admin.c                                |  23 +++-
> >  src/locking/lock_daemon.c                          | 132 +++++++++++++++-----
> >  src/locking/lock_daemon_config.c                   |   3 +
> >  src/locking/lock_daemon_config.h                   |   1 +
> >  src/locking/test_virtlockd.aug.in                  |   4 +
> >  src/locking/virtlockd-admin.socket.in              |  10 ++
> >  src/locking/virtlockd.aug                          |   1 +
> >  src/locking/virtlockd.conf                         |   6 +
> >  src/locking/virtlockd.service.in                   |   1 +
> >  src/logging/log_daemon.c                           | 135 +++++++++++++++------
> >  src/logging/log_daemon_config.c                    |   3 +
> >  src/logging/log_daemon_config.h                    |   1 +
> >  src/logging/test_virtlogd.aug.in                   |   4 +
> >  src/logging/virtlogd-admin.socket.in               |  10 ++
> >  src/logging/virtlogd.aug                           |   1 +
> >  src/logging/virtlogd.service.in                    |   1 +
> >  src/util/virutil.c                                 |  45 +++++++
> >  src/util/virutil.h                                 |   1 +
> >  29 files changed, 371 insertions(+), 137 deletions(-)
> >  rename {daemon => src/admin}/admin_server.c (99%)
> >  rename {daemon => src/admin}/admin_server.h (96%)
> >  rename daemon/admin.c => src/admin/admin_server_dispatch.c (96%)
> >  rename daemon/admin.h => src/admin/admin_server_dispatch.h (83%)
> >  create mode 100644 src/locking/virtlockd-admin.socket.in
> >  create mode 100644 src/logging/virtlogd-admin.socket.in
> > 
> 
> ACK if you fix all the nits I've found.

I'm going to repost due to the fact that exec-restart is fubar in this
version.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|