[libvirt] [PATCH 7/8] virsh: Introduce virshSecretUUIDCompleter

[John Ferlan]

On 01/12/2018 09:37 AM, Michal Privoznik wrote:
> This is a slight change from previous patches since virSecret
> does not have a name only UUID strings.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tools/virsh-completer.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>  tools/virsh-completer.h |  4 ++++
>  tools/virsh-secret.c    | 15 ++++++++++-----
>  3 files changed, 60 insertions(+), 5 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>

John


[...]

>  };
> @@ -667,7 +671,8 @@ static const vshCmdInfo info_secret_event[] = {
>  static const vshCmdOptDef opts_secret_event[] = {
>      {.name = "secret",
>       .type = VSH_OT_STRING,
> -     .help = N_("filter by secret name or uuid")
> +     .help = N_("filter by secret name or uuid"),

Wonder what a secret name is? ;-)  I know separate issue...  This and
the virsh.pod should be adjusted.

> +     .completer = virshSecretUUIDCompleter,
>      },
>      {.name = "event",
>       .type = VSH_OT_STRING,
>