[libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

[Erik Skultety]

On Mon, Jan 22, 2018 at 08:58:52AM -0500, John Ferlan wrote:
>
>
> On 01/22/2018 07:05 AM, Daniel P. Berrange wrote:
> > This extends the update hook so that it enforces a requirement to have a
> > Signed-off-by line in every commit message. This can be optionally
> > turned off in individual repos by setting the "hooks.allowmissingsob"
> > git config variable.
> >
> > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> > ---
> >  update | 16 +++++++++++++++-
> >  1 file changed, 15 insertions(+), 1 deletion(-)
> >

I've been using it since there was the first mention of it on the list and
because it didn't add any burden to my daily work and couldn't honestly be
simpler to configure, I don't have any objections to this move whatsoever.

>
> Count me in as in favor of this.  I have only ever had to add:
>
> [format]
> 	signoff = true
>
> to my $HOME/.gitconfig once and it's been in place ever since.  This is
> far less than the:
>
> [user] and [sendemail] sections and the same amount of additions to/for
> the [push] section.  One extra line.
>
> It's also less than anything I've had to add to my repository specific
> .git/config files.
>
> It's also easier than the :
>
> Reviewed-by: John Ferlan <jferlan at redhat.com>
>
> line that I keep in a "cheats" file that I always have open so that I
> don't have to add it for patches I review.  Of course, I could also just
> say ACK, but the R-b seems so much more authoritative.  Now if I could
> only remember or figure out a way to add it to any patches I push
> without having to remember to go back and rebase --interactive to add it

You're looking for git interpret-trailers...Ironically, I haven't been using it
even though I've known about it for quite some while, oh sigh, now's the right
time to do it.

Erik