[libvirt] [PATCH 01/14] storage: extract storage file backend from main storage driver backend

[Peter Krempa]

On Thu, Jan 25, 2018 at 09:38:12 +0000, Daniel Berrange wrote:
> The storage driver backends are serving the public storage pools API,
> while the storage file backends are serving the internal QEMU driver and
> / or libvirt utility code.
> 
> To prep for moving this storage file backend framework into the utility
> code, split out the backend definitions.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  po/POTFILES.in                        |   1 +
>  src/Makefile.am                       |   1 +
>  src/storage/storage_backend.c         |  66 ---------------------
>  src/storage/storage_backend.h         |  75 -----------------------
>  src/storage/storage_backend_fs.c      |   7 ++-
>  src/storage/storage_backend_gluster.c |   3 +-
>  src/storage/storage_source.c          |   2 +-
>  src/storage/storage_source_backend.c  | 108 ++++++++++++++++++++++++++++++++++
>  src/storage/storage_source_backend.h  | 104 ++++++++++++++++++++++++++++++++
>  9 files changed, 221 insertions(+), 146 deletions(-)
>  create mode 100644 src/storage/storage_source_backend.c
>  create mode 100644 src/storage/storage_source_backend.h
> 

[...]

> diff --git a/src/storage/storage_source_backend.h b/src/storage/storage_source_backend.h
> new file mode 100644
> index 0000000000..8288bebb1f
> --- /dev/null
> +++ b/src/storage/storage_source_backend.h
> @@ -0,0 +1,104 @@
> +/*
> + * storage_source_backend.h: internal storage source backend contract
> + *
> + * Copyright (C) 2007-2018 Red Hat, Inc.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library.  If not, see
> + * <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef __VIR_STORAGE_SOURCE_BACKEND_H__
> +# define __VIR_STORAGE_SOURCE_BACKEND_H__


[...]

> +
> +
> +int virStorageFileBackendRegister(virStorageFileBackendPtr backend);
> +
> +#endif /* __VIR_STORAGE_BACKEND_H__ */

The comment is not matching the previously defined macro.

ACK with it fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180125/489c888a/attachment-0001.sig>