[libvirt] [PATCH 1/3] virshDomainNameCompleter: Prune accepted flags

Michal Privoznik mprivozn at redhat.com
Thu Jan 25 14:22:18 UTC 2018


Only a small subset of VIR_CONNECT_LIST_DOMAINS_* flags are
actually used in virsh code. Remove the unused ones.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tools/virsh-completer.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c
index e216d9076..e3b8234b4 100644
--- a/tools/virsh-completer.c
+++ b/tools/virsh-completer.c
@@ -45,18 +45,11 @@ virshDomainNameCompleter(vshControl *ctl,
 
     virCheckFlags(VIR_CONNECT_LIST_DOMAINS_ACTIVE |
                   VIR_CONNECT_LIST_DOMAINS_INACTIVE |
+                  VIR_CONNECT_LIST_DOMAINS_OTHER |
+                  VIR_CONNECT_LIST_DOMAINS_PAUSED |
                   VIR_CONNECT_LIST_DOMAINS_PERSISTENT |
-                  VIR_CONNECT_LIST_DOMAINS_TRANSIENT |
                   VIR_CONNECT_LIST_DOMAINS_RUNNING |
-                  VIR_CONNECT_LIST_DOMAINS_PAUSED |
-                  VIR_CONNECT_LIST_DOMAINS_SHUTOFF |
-                  VIR_CONNECT_LIST_DOMAINS_OTHER |
-                  VIR_CONNECT_LIST_DOMAINS_MANAGEDSAVE |
-                  VIR_CONNECT_LIST_DOMAINS_NO_MANAGEDSAVE |
-                  VIR_CONNECT_LIST_DOMAINS_AUTOSTART |
-                  VIR_CONNECT_LIST_DOMAINS_NO_AUTOSTART |
-                  VIR_CONNECT_LIST_DOMAINS_HAS_SNAPSHOT |
-                  VIR_CONNECT_LIST_DOMAINS_NO_SNAPSHOT,
+                  VIR_CONNECT_LIST_DOMAINS_SHUTOFF,
                   NULL);
 
     if (!priv->conn || virConnectIsAlive(priv->conn) <= 0)
-- 
2.13.6




More information about the libvir-list mailing list