[libvirt] [PATCH 3/3] tools: Make symlinks to vsh bash-completion script

Michal Privoznik mprivozn at redhat.com
Thu Jan 25 14:22:20 UTC 2018

The bash-completion project documents that only those scripts
from $BASH_COMPLETIONS_DIR that share name with the current
command for which <TAB> was hit are loaded [1]. This means, that
vsh script we have there is not loaded. We have to create
symlinks for virsh and virt-admin.

At the same time, we have to create new RPM package because
virt-admin and client packages are independent. That means we
cannot place the vsh script in either of them. What we can do is
to have a different package that contains the completion script
and then virt-admin and client packages contain only the symlink
and require the bash-completion package.

1: https://github.com/scop/bash-completion#faq

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
 libvirt.spec.in   | 24 +++++++++++++++++++++++-
 tools/Makefile.am |  7 ++++++-
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index f62d7d324..1879e1f8b 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1017,6 +1017,9 @@ Requires: gnutls-utils
 # Needed for probing the power management features of the host.
 Requires: pm-utils
+%if %{with_bash_completion}
+Requires: %{name}-bash-completion = %{version}-%{release}
 %description client
 The client binaries needed to access the virtualization
@@ -1041,10 +1044,22 @@ Summary: Set of tools to control libvirt daemon
 Group: Development/Libraries
 Requires: %{name}-libs = %{version}-%{release}
 Requires: readline
+%if %{with_bash_completion}
+Requires: %{name}-bash-completion = %{version}-%{release}
 %description admin
 The client side utilities to control the libvirt daemon.
+%if %{with_bash_completion}
+%package bash-completion
+Summary: Bash completion script
+Group: Development/Libraries
+%description bash-completion
+Bash completion script stub.
 %if %{with_wireshark}
 %package wireshark
 Summary: Wireshark dissector plugin for libvirt RPC transactions
@@ -2059,7 +2074,7 @@ exit 0
 %if %{with_bash_completion}
@@ -2111,7 +2126,14 @@ exit 0
 %files admin
+%if %{with_bash_completion}
+%if %{with_bash_completion}
+%files bash-completion
 %if %{with_wireshark}
 %files wireshark
diff --git a/tools/Makefile.am b/tools/Makefile.am
index e9597cdb4..e173f5634 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -424,9 +424,14 @@ install-bash-completion:
 	$(INSTALL_SCRIPT) $(srcdir)/bash-completion/vsh \
+		$(LN_S) vsh virsh && \
+		$(LN_S) vsh virt-admin )

More information about the libvir-list mailing list