[libvirt] [PATCH v2] docs: formatdomain: Document the CPU feature 'name' attribute

Eduardo Habkost ehabkost at redhat.com
Thu Jan 25 14:36:11 UTC 2018

On Thu, Jan 25, 2018 at 09:17:22AM -0500, John Ferlan wrote:
> [...]
> >>
> >>> +        <code>name</code> attribute. For example, to explicitly specify
> >>
> >> s/specify/require
> > 
> > I used the verb 'specify' to indicate that there is an _action_ to be
> > taken.  To my non-native ears: "to explicitly require" sounds slightly
> > odd when asking to take an action.
> > 
> > But I'll defer to your native tounge intuition.
> > 
> FWIW: I noted require because the generated XML in the example is:
>  <feature policy='require' name='pcid'/>
> I'm OK with the change from v3, but the XML is what I was keying off.
> Essentially the line (to me) says, this domain requires a CPU that is
> required to have the 'pcid' feature. Perhaps just being too literal though.

IMO, "requiring a CPU" is not the important part.  The most
important consequence of <feature/> is changing what exactly the
guest will see on the virtual CPU.  On most cases, this requires
a host CPU that provides the feature, but it's just a
consequence of how it works, not the main goal.


More information about the libvir-list mailing list