[libvirt] [PATCH] qemu: Fix memory leak in processGuestPanicEvent

Michal Privoznik mprivozn at redhat.com
Sun Jan 28 13:03:01 UTC 2018


On 01/26/2018 09:43 PM, John Ferlan wrote:
> After processing the processEvent->data for a qemuProcessEventHandler
> callout, it's expected that the called processEvent->eventType helper
> will perform the proper free on the data field. In this case it's
> a qemuMonitorEventPanicInfoPtr.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> 
>  Noticed this while working through the DumpComplete patch series.
>  One has to follow the bouncing ball, but will note that when the
>  processEvent->data is passed to other cases, it ends up getting
>  VIR_FREE()'d at the end of various functions, so this should too
>  since it's at the end of the line.
> 
>  src/qemu/qemu_driver.c | 1 +
>  1 file changed, 1 insertion(+)

ACK

Michal




More information about the libvir-list mailing list