[libvirt] [PATCH 2/2] util: storage: Parse 'lun' for iSCSI protocol from JSON as string or number
Jiri Denemark
jdenemar at redhat.com
Wed Jan 31 11:17:46 UTC 2018
On Wed, Jan 31, 2018 at 12:07:32 +0100, Peter Krempa wrote:
> While the QEMU QAPI schema describes 'lun' as a number, the code dealing
> with JSON strings does not strictly adhere to this schema and thus
> formats the number back as a string. Use the new helper to retrieve both
> possibilities.
>
> Note that the formatting code is okay and qemu will accept it as an int.
>
> Tweak also one of the test stringst to verify that both formats work
s/stringst/strings/
> with libvirt.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1540290
> ---
> src/util/virstoragefile.c | 13 +++++--------
> tests/virstoragetest.c | 2 +-
> 2 files changed, 6 insertions(+), 9 deletions(-)
ACK
Jirka
More information about the libvir-list
mailing list