[libvirt] [PATCH 09/10] storage: open secret driver connection at time of use

[Daniel P. Berrangé]

On Mon, Jan 29, 2018 at 07:44:18AM +0100, Michal Privoznik wrote:
> On 01/26/2018 02:35 PM, Daniel P. Berrangé wrote:
> > Instead of passing around a virConnectPtr object, just open a connection
> > to the secret driver at time of use. Opening connections on demand will
> > be beneficial when the secret driver is in a separate daemon. It also
> > solves the problem that a number of callers just pass in a NULL
> > connection today which prevents secret lookup working at all.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/storage/storage_backend_iscsi.c   | 14 +++---
> >  src/storage/storage_backend_logical.c |  2 +-
> >  src/storage/storage_backend_rbd.c     | 41 +++++++--------
> >  src/storage/storage_util.c            | 95 ++++++++++++++++-------------------
> >  src/storage/storage_util.h            |  6 +--
> >  5 files changed, 71 insertions(+), 87 deletions(-)
> 
> ACK with this squashed in:
> 
> diff --git i/tests/storagevolxml2argvtest.c w/tests/storagevolxml2argvtest.c
> index 1cd083766..efb80b9cf 100644
> --- i/tests/storagevolxml2argvtest.c
> +++ w/tests/storagevolxml2argvtest.c
> @@ -84,7 +84,7 @@ testCompareXMLToArgvFiles(bool shouldFail,
>      testSetVolumeType(vol, def);
>      testSetVolumeType(inputvol, inputpool);
>  
> -    cmd = virStorageBackendCreateQemuImgCmdFromVol(conn, obj, vol,
> +    cmd = virStorageBackendCreateQemuImgCmdFromVol(obj, vol,
>                                                     inputvol, flags,
>                                                     create_tool, imgformat,
>                                                     NULL);


Opps, yes.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|