[libvirt] [PATCH v2] qemu: format serial and geometry on frontend disk device

[Daniel P. Berrangé]

On Mon, Jul 02, 2018 at 10:49:09AM +0200, Peter Krempa wrote:
> On Mon, Jul 02, 2018 at 09:26:38 +0100, Daniel Berrange wrote:
> > Currently we format the serial, geometry and error policy on the -drive
> > backend argument.
> > 
> > QEMU added the ability to set serial and geometry on the frontend in
> > the 1.2 release deprecating use of -drive, with support being deleted
> > from -drive in 3.0.
> > 
> > We keep formatting error policy on -drive for now, because we don't
> > ahve support for that with -device for usb-storage just yet.
> > 
> > Note that some disk buses (sd) still don't support -device. Although
> > QEMU allowed these properties to be set on -drive for if=sd, they
> > have been ignored so we now report an error in this case.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/qemu/qemu_command.c                       | 26 +++++++++++++++----
> >  .../disk-drive-network-tlsx509.args           | 12 ++++-----
> >  .../disk-drive-network-vxhs.args              |  4 +--
> >  tests/qemuxml2argvdata/disk-drive-shared.args |  5 ++--
> >  tests/qemuxml2argvdata/disk-geometry.args     |  6 ++---
> >  tests/qemuxml2argvdata/disk-ide-wwn.args      |  5 ++--
> >  .../qemuxml2argvdata/disk-scsi-disk-wwn.args  |  4 +--
> >  tests/qemuxml2argvdata/disk-serial.args       | 10 +++----
> >  tests/qemuxml2argvdata/disk-serial.xml        |  1 -
> >  tests/qemuxml2xmloutdata/disk-serial.xml      |  1 -
> >  10 files changed, 44 insertions(+), 30 deletions(-)
> 
> ACK

Damn self-NACK

The 'trans' property was renamed to 'bios-chs-trans', and is only valid on
IDE, not SCSI/virtio

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|