[libvirt] [dbus PATCH] AUTHORS: Update maintainers and original authors
Pavel Hrdina
phrdina at redhat.com
Wed Jul 4 06:07:55 UTC 2018
On Wed, Jul 04, 2018 at 07:57:56AM +0200, Andrea Bolognani wrote:
> On Wed, 2018-07-04 at 07:35 +0200, Pavel Hrdina wrote:
> > Create section for authors that started the project and add Katerina
> > into the list of primary maintainers.
> >
> > Suggested-by: Andrea Bolognani <abologna at redhat.com>
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>
> One day I will learn to check the list before posting patches O:-)
>
> [...]
> > -The primary maintainers of libvirt-dbus are:
> > +The libvirt-dbus project was initiated by:
>
> "Initiated" doesn't sound quite right in this context, what about
> "started" (which, incidentally, you used in the commit message :)
> or "created"?
Right, "started" sounds better.
> [...]
> > Patches have been received from:
> >
> > #authorslist#
>
> Aside: right at the bottom of the file, we have
>
> ... send patches to get your name added ...
>
> which seems quite useless to me, given that the list of
> contributors is generated from the git log. I suggest dropping it,
> but that's of course not in scope for this patch.
I've copied that line from libvirt AUTHORS.in file. Now that I'm
reading it again it can have a second meaning like make a contribution
in order to be listed but even with that meaning it can be removed
because it's kind of obvious.
Feel free to send a patch :) I personally don't care that much.
> With the nit mentioned above fixed,
>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
Thanks, fixed and pushed.
Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180704/c4f6e982/attachment-0001.sig>
More information about the libvir-list
mailing list