[libvirt] [PATCH 1/6] qemuBuildSCSIiSCSIHostdevDrvStr: Don't leak @netsource and @srcprops

Peter Krempa pkrempa at redhat.com
Mon Jul 9 10:54:41 UTC 2018


On Mon, Jul 09, 2018 at 11:56:09 +0200, Michal Privoznik wrote:
> After 6b770f9a3bdabb1 both @netsource and @srcprops are leaked
> because of early return introduced in the commit.

I'd revert this commit completely. The change seems pointless to me.

> 
> ==1812== 644 bytes in 4 blocks are definitely lost in loss record 835 of 885
> ==1812==    at 0x4C2F12F: realloc (vg_replace_malloc.c:785)
> ==1812==    by 0x8846393: xmlSaveUriRealloc (in /usr/lib64/libxml2.so.2.9.8)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180709/93177cb7/attachment-0001.sig>


More information about the libvir-list mailing list