[libvirt] [PATCH] Changed LPC slot from 1 to 31

[Ivan Mishonov]

Yes, I talked to him and he said he will review and test. Thanks


On 07/09/2018 05:17 PM, Daniel P. Berrangé wrote:
> On Mon, Jul 09, 2018 at 05:14:35PM +0300, Ivan Mishonov wrote:
>> ---
>>   src/bhyve/bhyve_command.c | 2 +-
>>   src/bhyve/bhyve_device.c  | 4 ++--
>>   2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
>> index 802997bd2d..e595b3d6c1 100644
>> --- a/src/bhyve/bhyve_command.c
>> +++ b/src/bhyve/bhyve_command.c
>> @@ -329,7 +329,7 @@ static int
>>   bhyveBuildLPCArgStr(const virDomainDef *def ATTRIBUTE_UNUSED,
>>                       virCommandPtr cmd)
>>   {
>> -    virCommandAddArgList(cmd, "-s", "1,lpc", NULL);
>> +    virCommandAddArgList(cmd, "-s", "31,lpc", NULL);
>>       return 0;
>>   }
>>   
>> diff --git a/src/bhyve/bhyve_device.c b/src/bhyve/bhyve_device.c
>> index 03aa6c93bd..2ed3013552 100644
>> --- a/src/bhyve/bhyve_device.c
>> +++ b/src/bhyve/bhyve_device.c
>> @@ -48,9 +48,9 @@ bhyveCollectPCIAddress(virDomainDefPtr def ATTRIBUTE_UNUSED,
>>       if (addr->domain == 0 && addr->bus == 0) {
>>           if (addr->slot == 0) {
>>               return 0;
>> -        } else if (addr->slot == 1) {
>> +        } else if (addr->slot == 31) {
>>               virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
>> -                           _("PCI bus 0 slot 1 is reserved for the implicit "
>> +                           _("PCI bus 0 slot 31 is reserved for the implicit "
>>                                "LPC PCI-ISA bridge"));
>>               return -1;
>>           }
> Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
>
> but i won't push this, as Roman should double check in case there was an
> important reason he chose slot 1 originally.
>
> Regards,
> Daniel