[libvirt] Ping? Re: [PATCH] qemu: stop qemu progress when restore failed

[WangJie (Pluto)]

I feel so sorry for my impolite behavior, and waitting for your review opinions :)

On 2018/7/9 17:06, Peter Krempa wrote:
> On Mon, Jul 09, 2018 at 16:39:53 +0800, WangJie (Pluto) wrote:
>> ping...
> 
> Please don't be impatient. Pinging patches after one day is kind of rude
> to the reviewers. Not getting a review after 1 day does not mean we
> ignored that patch. The same applies for the weekend. People don't
> usually work over the weekend. Too eager pinging may actually lead to
> ignoring your patches.
> 
>>
>> On 2018/7/5 10:05, Jie Wang wrote:
>>> >From 29482622218f525f0133be0b7db74835174035d9 Mon Sep 17 00:00:00 2001
>>> From: Jie Wang <wangjie88 at huawei.com>
>>> Date: Thu, 5 Jul 2018 09:52:03 +0800
>>> Subject: [PATCH] qemu: stop qemu progress when restore failed
>>>
>>> if qemuProcessStartCPUs perform failed in qemuDomainSaveImageStartVM,
>>> we need to stop qemu progress, otherwise will remains a wild VM
>>> which can't be managed by libvirt.
>>>
>>> Signed-off-by: Jie Wang <wangjie88.huawei.com>
>>> ---
>>>  src/qemu/qemu_driver.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>>> index 9a35e04a85..639b57316d 100644
>>> --- a/src/qemu/qemu_driver.c
>>> +++ b/src/qemu/qemu_driver.c
>>> @@ -6621,6 +6621,8 @@ qemuDomainSaveImageStartVM(virConnectPtr conn,
>>>              if (virGetLastErrorCode() == VIR_ERR_OK)
>>>                  virReportError(VIR_ERR_OPERATION_FAILED,
>>>                                 "%s", _("failed to resume domain"));
>>> +
>>> +            qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, 0);
>>>              goto cleanup;
>>>          }
>>>          if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) {
>>>
>>
>> --
>> libvir-list mailing list
>> libvir-list at redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list