[libvirt] [PATCH 2/2 v2] qemu: monitor: Make qemuMonitorAddObject more robust against programming errors

Ján Tomko jtomko at redhat.com
Tue Jul 10 14:50:22 UTC 2018


On Wed, Jul 04, 2018 at 04:51:04PM +0200, Peter Krempa wrote:
>Document and check that @props contains a pointer to a json object and
>check that both necessary fields are present. Also mark @props as
>NONNULL.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
>Diff:
>- added the not commited fix to add "%s" to the error message so
>as a syntax-check fix
>- typo fix in commit message
>
>
> src/qemu/qemu_monitor.c | 23 +++++++++++++++++------
> src/qemu/qemu_monitor.h |  3 ++-
> 2 files changed, 19 insertions(+), 7 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180710/140dabd8/attachment-0001.sig>


More information about the libvir-list mailing list