[libvirt] [PATCH v2 1/5] qemuxml2argvtest: Set more fake drivers

Michal Privoznik mprivozn at redhat.com
Thu Jul 12 09:12:26 UTC 2018


On 07/12/2018 11:08 AM, Peter Krempa wrote:
> On Thu, Jul 12, 2018 at 11:00:42 +0200, Michal Privoznik wrote:
>> On 07/12/2018 10:56 AM, Peter Krempa wrote:
> 
> [...]
> 
>> Also, can I get review on the rest of the patches please? I noticed some
>> people started replying only to a single patch in a series leaving the
>> rest unreviewed. I don't think that's good.
> 
> I did not plan to review this series. I think it's warranted to point
> out a problem with a patch even if you would not review that series
> otherwise.
> 

Well, unless reviewers are reading every e-mail in every thread, they
will see a discussion to this thread thinking there is an review going
on and thus skip to next (unreviewed) thread. This is usually my experience.

So while pointing out problems is a good thing to do, leaving the rest
unreviewed isn't IMO.

Michal




More information about the libvir-list mailing list