[libvirt] [PATCHv2 04/11] qemu_monitor: Introduce qemuMonitorCPUModelInfoInit and qemuMonitorCPUModelInfoFreeContents
Jiri Denemark
jdenemar at redhat.com
Thu Jul 12 13:13:07 UTC 2018
On Mon, Jul 09, 2018 at 22:56:48 -0500, Chris Venteicher wrote:
> These forms modify contents of a qemuMonitorCPUModelInfo structure but
> do not allocate or free the actual structure.
>
> Init - Initialize model name and empty properties within existing structure
> FreeContents - Free model name and properties within existing structure
We call such function with "Clear" suffix, i.e.,
qemuMonitorCPUModelInfoClear.
But it is usually used when we have a structure stored somewhere
directly rather than having a pointer to it. And this was not the case
so far and I don't think there's any reason to introduce a code which
would need any of these functions.
NACK to this patch.
Jirka
More information about the libvir-list
mailing list