[libvirt] [PATCH 1/2] virDevMapperGetTargetsImpl: Be tolerant to kernels without DM support

Michal Privoznik mprivozn at redhat.com
Fri Jul 13 13:48:26 UTC 2018


https://bugzilla.redhat.com/show_bug.cgi?id=1591732

If kernel is compiled without CONFIG_BLK_DEV_DM enabled, there is
no /dev/mapper/control device and since dm_task_create() actually
does some ioctl() over it creating a task may fail.
To cope with this handle ENOENT and ENODEV gracefully.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/util/virdevmapper.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/util/virdevmapper.c b/src/util/virdevmapper.c
index b365f20145..7da0dba911 100644
--- a/src/util/virdevmapper.c
+++ b/src/util/virdevmapper.c
@@ -87,8 +87,14 @@ virDevMapperGetTargetsImpl(const char *path,
         return ret;
     }
 
-    if (!(dmt = dm_task_create(DM_DEVICE_DEPS)))
+    if (!(dmt = dm_task_create(DM_DEVICE_DEPS))) {
+        if (errno == ENOENT || errno == ENODEV) {
+            /* It's okay. Kernel is probably built without
+             * devmapper support. */
+            ret = 0;
+        }
         return ret;
+    }
 
     if (!dm_task_set_name(dmt, path)) {
         if (errno == ENOENT) {
-- 
2.16.4




More information about the libvir-list mailing list