[libvirt] [PATCH] util: remove unused variable inside virFileReadValueString().

Roman Bogorodskiy bogorodskiy at gmail.com
Sat Jul 14 16:41:15 UTC 2018


  Julio Faracco wrote:

> The commit 69b937f0358 introduced VIR_AUTOFREE and this macro removed
> VIR_FREE. This change showed that 'str' variable was not being used
> inside this method. This commit removes this unused variable.
> 
> Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
> ---
>  src/util/virfile.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Roman Bogorodskiy <bogorodskiy at gmail.com>

And pushed.

> diff --git a/src/util/virfile.c b/src/util/virfile.c
> index 6b94885a87..1faeebbdb5 100644
> --- a/src/util/virfile.c
> +++ b/src/util/virfile.c
> @@ -4228,7 +4228,6 @@ int
>  virFileReadValueString(char **value, const char *format, ...)
>  {
>      int ret;
> -    VIR_AUTOFREE(char *) str = NULL;
>      VIR_AUTOFREE(char *) path = NULL;
>      va_list ap;
>  
> -- 
> 2.17.1
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180714/fc952813/attachment-0001.sig>


More information about the libvir-list mailing list