[libvirt] [go PATCH 36/37] error: make GetNotImplementedError private

Daniel P. Berrangé berrange at redhat.com
Mon Jul 16 13:24:22 UTC 2018


The GetNotImplementedError() method is only for internal use so should
not have a public name.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 connect.go             | 24 +++++++++---------
 domain.go              | 56 +++++++++++++++++++++---------------------
 error.go               |  2 +-
 lxc.go                 |  2 +-
 network.go             |  2 +-
 network_events.go      |  4 +--
 node_device_events.go  |  4 +--
 nwfilter_binding.go    | 12 ++++-----
 qemu.go                |  4 +--
 secret_events.go       |  6 ++---
 storage_pool_events.go |  6 ++---
 storage_volume.go      |  2 +-
 stream.go              | 10 ++++----
 13 files changed, 67 insertions(+), 67 deletions(-)

diff --git a/connect.go b/connect.go
index 29e4fb0..34a96ed 100644
--- a/connect.go
+++ b/connect.go
@@ -857,7 +857,7 @@ func (c *Connect) DomainDefineXML(xmlConfig string) (*Domain, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDefineXMLFlags
 func (c *Connect) DomainDefineXMLFlags(xmlConfig string, flags DomainDefineFlags) (*Domain, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002012 {
-		return nil, GetNotImplementedError("virDomainDefineXMLFlags")
+		return nil, makeNotImplementedError("virDomainDefineXMLFlags")
 	}
 	cXml := C.CString(string(xmlConfig))
 	defer C.free(unsafe.Pointer(cXml))
@@ -1266,7 +1266,7 @@ func (c *Connect) LookupStoragePoolByUUID(uuid []byte) (*StoragePool, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-storage.html#virStoragePoolLookupByTargetPath
 func (c *Connect) LookupStoragePoolByTargetPath(path string) (*StoragePool, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4001000 {
-		return nil, GetNotImplementedError("virStoragePoolLookupByTargetPath")
+		return nil, makeNotImplementedError("virStoragePoolLookupByTargetPath")
 	}
 	cPath := C.CString(path)
 	defer C.free(unsafe.Pointer(cPath))
@@ -1335,7 +1335,7 @@ func (c *Connect) LookupNWFilterByUUID(uuid []byte) (*NWFilter, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterBindingLookupByPortDev
 func (c *Connect) LookupNWFilterBindingByPortDev(name string) (*NWFilterBinding, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return nil, GetNotImplementedError("virNWFilterBindingLookupByPortDev")
+		return nil, makeNotImplementedError("virNWFilterBindingLookupByPortDev")
 	}
 	cName := C.CString(name)
 	defer C.free(unsafe.Pointer(cName))
@@ -1555,7 +1555,7 @@ func (c *Connect) ListAllNWFilters(flags uint32) ([]NWFilter, error) {
 func (c *Connect) ListAllNWFilterBindings(flags uint32) ([]NWFilterBinding, error) {
 	var cList *C.virNWFilterBindingPtr
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return []NWFilterBinding{}, GetNotImplementedError("virConnectListAllNWFilterBindings")
+		return []NWFilterBinding{}, makeNotImplementedError("virConnectListAllNWFilterBindings")
 	}
 	var err C.virError
 	numNWFilters := C.virConnectListAllNWFilterBindingsWrapper(c.ptr, (**C.virNWFilterBindingPtr)(&cList), C.uint(flags), &err)
@@ -1675,7 +1675,7 @@ func (c *Connect) InterfaceChangeRollback(flags uint32) error {
 // See also https://libvirt.org/html/libvirt-libvirt-host.html#virNodeAllocPages
 func (c *Connect) AllocPages(pageSizes map[int]int64, startCell int, cellCount uint, flags NodeAllocPagesFlags) (int, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002009 {
-		return 0, GetNotImplementedError("virNodeAllocPages")
+		return 0, makeNotImplementedError("virNodeAllocPages")
 	}
 	cpages := make([]C.uint, len(pageSizes))
 	ccounts := make([]C.ulonglong, len(pageSizes))
@@ -1812,7 +1812,7 @@ func (c *Connect) GetFreeMemory() (uint64, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-host.html#virNodeGetFreePages
 func (c *Connect) GetFreePages(pageSizes []uint64, startCell int, maxCells uint, flags uint32) ([]uint64, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002006 {
-		return []uint64{}, GetNotImplementedError("virNodeGetFreePages")
+		return []uint64{}, makeNotImplementedError("virNodeGetFreePages")
 	}
 	cpageSizes := make([]C.uint, len(pageSizes))
 	ccounts := make([]C.ulonglong, len(pageSizes)*int(maxCells))
@@ -2087,7 +2087,7 @@ func (c *Connect) BaselineCPU(xmlCPUs []string, flags ConnectBaselineCPUFlags) (
 // See also https://libvirt.org/html/libvirt-libvirt-host.html#virConnectBaselineHypervisorCPU
 func (c *Connect) BaselineHypervisorCPU(emulator string, arch string, machine string, virttype string, xmlCPUs []string, flags ConnectBaselineCPUFlags) (string, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4004000 {
-		return "", GetNotImplementedError("virConnectBaselineHypervisorCPU")
+		return "", makeNotImplementedError("virConnectBaselineHypervisorCPU")
 	}
 
 	var cemulator, carch, cmachine, cvirttype *C.char
@@ -2142,7 +2142,7 @@ func (c *Connect) CompareCPU(xmlDesc string, flags ConnectCompareCPUFlags) (CPUC
 // See also https://libvirt.org/html/libvirt-libvirt-host.html#virConnectCompareHypervisorCPU
 func (c *Connect) CompareHypervisorCPU(emulator string, arch string, machine string, virttype string, xmlDesc string, flags ConnectCompareCPUFlags) (CPUCompareResult, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4004000 {
-		return CPU_COMPARE_ERROR, GetNotImplementedError("virConnectCompareHypervisorCPU")
+		return CPU_COMPARE_ERROR, makeNotImplementedError("virConnectCompareHypervisorCPU")
 	}
 
 	var cemulator, carch, cmachine, cvirttype *C.char
@@ -2238,7 +2238,7 @@ func (c *Connect) GetCPUModelNames(arch string, flags uint32) ([]string, error)
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectGetDomainCapabilities
 func (c *Connect) GetDomainCapabilities(emulatorbin string, arch string, machine string, virttype string, flags uint32) (string, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002007 {
-		return "", GetNotImplementedError("virConnectGetDomainCapabilities")
+		return "", makeNotImplementedError("virConnectGetDomainCapabilities")
 	}
 	var cemulatorbin *C.char
 	if emulatorbin != "" {
@@ -2776,7 +2776,7 @@ func getDomainStatsLengthsFieldInfo(params *domainStatsLengths) map[string]typed
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectGetAllDomainStats
 func (c *Connect) GetAllDomainStats(doms []*Domain, statsTypes DomainStatsTypes, flags ConnectGetAllDomainStatsFlags) ([]DomainStats, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002008 {
-		return []DomainStats{}, GetNotImplementedError("virConnectGetAllDomainStats")
+		return []DomainStats{}, makeNotImplementedError("virConnectGetAllDomainStats")
 	}
 	var ret C.int
 	var cstats *C.virDomainStatsRecordPtr
@@ -2953,7 +2953,7 @@ func getNodeSEVFieldInfo(params *NodeSEVParameters) map[string]typedParamsFieldI
 // See also https://libvirt.org/html/libvirt-libvirt-host.html#virNodeGetSEVInfo
 func (c *Connect) GetSEVInfo(flags uint32) (*NodeSEVParameters, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return nil, GetNotImplementedError("virNodeGetSEVInfo")
+		return nil, makeNotImplementedError("virNodeGetSEVInfo")
 	}
 
 	params := &NodeSEVParameters{}
@@ -2981,7 +2981,7 @@ func (c *Connect) GetSEVInfo(flags uint32) (*NodeSEVParameters, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virNWFilterBindingCreateXML
 func (c *Connect) NWFilterBindingCreateXML(xmlConfig string, flags uint32) (*NWFilterBinding, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return nil, GetNotImplementedError("virNWFilterBindingCreateXML")
+		return nil, makeNotImplementedError("virNWFilterBindingCreateXML")
 	}
 	cXml := C.CString(string(xmlConfig))
 	defer C.free(unsafe.Pointer(cXml))
diff --git a/domain.go b/domain.go
index 302cdb8..14a6485 100644
--- a/domain.go
+++ b/domain.go
@@ -1539,7 +1539,7 @@ func (d *Domain) DetachDeviceFlags(xml string, flags DomainDeviceModifyFlags) er
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDeviceAlias
 func (d *Domain) DetachDeviceAlias(alias string, flags DomainDeviceModifyFlags) error {
 	if C.LIBVIR_VERSION_NUMBER < 4004000 {
-		return GetNotImplementedError("virDomainDetachDeviceAlias")
+		return makeNotImplementedError("virDomainDetachDeviceAlias")
 	}
 
 	cAlias := C.CString(alias)
@@ -1924,7 +1924,7 @@ type DomainInterface struct {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainInterfaceAddresses
 func (d *Domain) ListAllInterfaceAddresses(src DomainInterfaceAddressesSource) ([]DomainInterface, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002014 {
-		return []DomainInterface{}, GetNotImplementedError("virDomainInterfaceAddresses")
+		return []DomainInterface{}, makeNotImplementedError("virDomainInterfaceAddresses")
 	}
 
 	var cList *C.virDomainInterfacePtr
@@ -2089,7 +2089,7 @@ func getBlockCopyParameterFieldInfo(params *DomainBlockCopyParameters) map[strin
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainBlockCopy
 func (d *Domain) BlockCopy(disk string, destxml string, params *DomainBlockCopyParameters, flags DomainBlockCopyFlags) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002008 {
-		return GetNotImplementedError("virDomainBlockCopy")
+		return makeNotImplementedError("virDomainBlockCopy")
 	}
 	cdisk := C.CString(disk)
 	defer C.free(unsafe.Pointer(cdisk))
@@ -2530,7 +2530,7 @@ func (d *Domain) MigrateGetMaxDowntime(flags uint32) (uint64, error) {
 	var downtimeLen C.ulonglong
 
 	if C.LIBVIR_VERSION_NUMBER < 3007000 {
-		return 0, GetNotImplementedError("virDomainMigrateGetMaxDowntime")
+		return 0, makeNotImplementedError("virDomainMigrateGetMaxDowntime")
 	}
 
 	var err C.virError
@@ -2545,7 +2545,7 @@ func (d *Domain) MigrateGetMaxDowntime(flags uint32) (uint64, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateStartPostCopy
 func (d *Domain) MigrateStartPostCopy(flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 1003003 {
-		return GetNotImplementedError("virDomainMigrateStartPostCopy")
+		return makeNotImplementedError("virDomainMigrateStartPostCopy")
 	}
 
 	var err C.virError
@@ -3548,7 +3548,7 @@ func getDomainPerfEventsFieldInfo(params *DomainPerfEvents) map[string]typedPara
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetPerfEvents
 func (d *Domain) GetPerfEvents(flags DomainModificationImpact) (*DomainPerfEvents, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1003003 {
-		return nil, GetNotImplementedError("virDomainGetPerfEvents")
+		return nil, makeNotImplementedError("virDomainGetPerfEvents")
 	}
 
 	params := &DomainPerfEvents{}
@@ -3575,7 +3575,7 @@ func (d *Domain) GetPerfEvents(flags DomainModificationImpact) (*DomainPerfEvent
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainSetPerfEvents
 func (d *Domain) SetPerfEvents(params *DomainPerfEvents, flags DomainModificationImpact) error {
 	if C.LIBVIR_VERSION_NUMBER < 1003003 {
-		return GetNotImplementedError("virDomainSetPerfEvents")
+		return makeNotImplementedError("virDomainSetPerfEvents")
 	}
 
 	info := getDomainPerfEventsFieldInfo(params)
@@ -3874,7 +3874,7 @@ func (d *Domain) GetSecurityLabelList() ([]SecurityLabel, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetTime
 func (d *Domain) GetTime(flags uint32) (int64, uint, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002005 {
-		return 0, 0, GetNotImplementedError("virDomainGetTime")
+		return 0, 0, makeNotImplementedError("virDomainGetTime")
 	}
 	var secs C.longlong
 	var nsecs C.uint
@@ -3890,7 +3890,7 @@ func (d *Domain) GetTime(flags uint32) (int64, uint, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainSetTime
 func (d *Domain) SetTime(secs int64, nsecs uint, flags DomainSetTimeFlags) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002005 {
-		return GetNotImplementedError("virDomainSetTime")
+		return makeNotImplementedError("virDomainSetTime")
 	}
 
 	var err C.virError
@@ -3905,7 +3905,7 @@ func (d *Domain) SetTime(secs int64, nsecs uint, flags DomainSetTimeFlags) error
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainSetUserPassword
 func (d *Domain) SetUserPassword(user string, password string, flags DomainSetUserPasswordFlags) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002015 {
-		return GetNotImplementedError("virDomainSetUserPassword")
+		return makeNotImplementedError("virDomainSetUserPassword")
 	}
 	cuser := C.CString(user)
 	cpassword := C.CString(password)
@@ -3960,7 +3960,7 @@ func (d *Domain) ManagedSaveRemove(flags uint32) error {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainRename
 func (d *Domain) Rename(name string, flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002019 {
-		return GetNotImplementedError("virDomainRename")
+		return makeNotImplementedError("virDomainRename")
 	}
 	cname := C.CString(name)
 	defer C.free(unsafe.Pointer(cname))
@@ -4023,7 +4023,7 @@ func (d *Domain) CoreDump(to string, flags DomainCoreDumpFlags) error {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainCoreDumpWithFormat
 func (d *Domain) CoreDumpWithFormat(to string, format DomainCoreDumpFormat, flags DomainCoreDumpFlags) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002003 {
-		GetNotImplementedError("virDomainCoreDumpWithFormat")
+		makeNotImplementedError("virDomainCoreDumpWithFormat")
 	}
 	cto := C.CString(to)
 	defer C.free(unsafe.Pointer(cto))
@@ -4053,7 +4053,7 @@ func (d *Domain) HasCurrentSnapshot(flags uint32) (bool, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainFSFreeze
 func (d *Domain) FSFreeze(mounts []string, flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002005 {
-		return GetNotImplementedError("virDomainFSFreeze")
+		return makeNotImplementedError("virDomainFSFreeze")
 	}
 	cmounts := make([](*C.char), len(mounts))
 
@@ -4075,7 +4075,7 @@ func (d *Domain) FSFreeze(mounts []string, flags uint32) error {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainFSThaw
 func (d *Domain) FSThaw(mounts []string, flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002005 {
-		return GetNotImplementedError("virDomainFSThaw")
+		return makeNotImplementedError("virDomainFSThaw")
 	}
 	cmounts := make([](*C.char), len(mounts))
 
@@ -4121,7 +4121,7 @@ type DomainFSInfo struct {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetFSInfo
 func (d *Domain) GetFSInfo(flags uint32) ([]DomainFSInfo, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002011 {
-		return []DomainFSInfo{}, GetNotImplementedError("virDomainGetFSInfo")
+		return []DomainFSInfo{}, makeNotImplementedError("virDomainGetFSInfo")
 	}
 	var cfsinfolist **C.virDomainFSInfo
 
@@ -4180,7 +4180,7 @@ func (d *Domain) PMWakeup(flags uint32) error {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainAddIOThread
 func (d *Domain) AddIOThread(id uint, flags DomainModificationImpact) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002015 {
-		return GetNotImplementedError("virDomainAddIOThread")
+		return makeNotImplementedError("virDomainAddIOThread")
 	}
 	var err C.virError
 	ret := C.virDomainAddIOThreadWrapper(d.ptr, C.uint(id), C.uint(flags), &err)
@@ -4194,7 +4194,7 @@ func (d *Domain) AddIOThread(id uint, flags DomainModificationImpact) error {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDelIOThread
 func (d *Domain) DelIOThread(id uint, flags DomainModificationImpact) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002015 {
-		return GetNotImplementedError("virDomainDelIOThread")
+		return makeNotImplementedError("virDomainDelIOThread")
 	}
 	var err C.virError
 	ret := C.virDomainDelIOThreadWrapper(d.ptr, C.uint(id), C.uint(flags), &err)
@@ -4240,7 +4240,7 @@ type DomainIOThreadInfo struct {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetIOThreadInfo
 func (d *Domain) GetIOThreadInfo(flags DomainModificationImpact) ([]DomainIOThreadInfo, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002014 {
-		return []DomainIOThreadInfo{}, GetNotImplementedError("virDomaingetIOThreadInfo")
+		return []DomainIOThreadInfo{}, makeNotImplementedError("virDomaingetIOThreadInfo")
 	}
 	var cinfolist **C.virDomainIOThreadInfo
 
@@ -4344,7 +4344,7 @@ func (d *Domain) PinEmulator(cpumap []bool, flags DomainModificationImpact) erro
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainPinIOThread
 func (d *Domain) PinIOThread(iothreadid uint, cpumap []bool, flags DomainModificationImpact) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002014 {
-		return GetNotImplementedError("virDomainPinIOThread")
+		return makeNotImplementedError("virDomainPinIOThread")
 	}
 
 	maplen := (len(cpumap) + 7) / 8
@@ -4412,7 +4412,7 @@ func (d *Domain) OpenGraphics(idx uint, file os.File, flags DomainOpenGraphicsFl
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainOpenGraphicsFD
 func (d *Domain) OpenGraphicsFD(idx uint, flags DomainOpenGraphicsFlags) (*os.File, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002008 {
-		return nil, GetNotImplementedError("virDomainOpenGraphicsFD")
+		return nil, makeNotImplementedError("virDomainOpenGraphicsFD")
 	}
 	var err C.virError
 	ret := C.virDomainOpenGraphicsFDWrapper(d.ptr, C.uint(idx), C.uint(flags), &err)
@@ -4544,7 +4544,7 @@ func parseCPUString(cpumapstr string) ([]bool, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetGuestVcpus
 func (d *Domain) GetGuestVcpus(flags uint32) (*DomainGuestVcpus, error) {
 	if C.LIBVIR_VERSION_NUMBER < 2000000 {
-		return nil, GetNotImplementedError("virDomainGetGuestVcpus")
+		return nil, makeNotImplementedError("virDomainGetGuestVcpus")
 	}
 
 	var VcpusSet, OnlineSet, OfflinableSet bool
@@ -4572,7 +4572,7 @@ func (d *Domain) GetGuestVcpus(flags uint32) (*DomainGuestVcpus, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainSetGuestVcpus
 func (d *Domain) SetGuestVcpus(cpus []bool, state bool, flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 2000000 {
-		return GetNotImplementedError("virDomainSetGuestVcpus")
+		return makeNotImplementedError("virDomainSetGuestVcpus")
 	}
 
 	cpumap := ""
@@ -4606,7 +4606,7 @@ func (d *Domain) SetGuestVcpus(cpus []bool, state bool, flags uint32) error {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainSetVcpu
 func (d *Domain) SetVcpu(cpus []bool, state bool, flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 3001000 {
-		return GetNotImplementedError("virDomainSetVcpu")
+		return makeNotImplementedError("virDomainSetVcpu")
 	}
 
 	cpumap := ""
@@ -4640,7 +4640,7 @@ func (d *Domain) SetVcpu(cpus []bool, state bool, flags uint32) error {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainSetBlockThreshold
 func (d *Domain) SetBlockThreshold(dev string, threshold uint64, flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 3002000 {
-		return GetNotImplementedError("virDomainSetBlockThreshold")
+		return makeNotImplementedError("virDomainSetBlockThreshold")
 	}
 
 	cdev := C.CString(dev)
@@ -4657,7 +4657,7 @@ func (d *Domain) SetBlockThreshold(dev string, threshold uint64, flags uint32) e
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainManagedSaveDefineXML
 func (d *Domain) ManagedSaveDefineXML(xml string, flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 3007000 {
-		return GetNotImplementedError("virDomainManagedSaveDefineXML")
+		return makeNotImplementedError("virDomainManagedSaveDefineXML")
 	}
 
 	cxml := C.CString(xml)
@@ -4674,7 +4674,7 @@ func (d *Domain) ManagedSaveDefineXML(xml string, flags uint32) error {
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainManagedSaveGetXMLDesc
 func (d *Domain) ManagedSaveGetXMLDesc(flags uint32) (string, error) {
 	if C.LIBVIR_VERSION_NUMBER < 3007000 {
-		return "", GetNotImplementedError("virDomainManagedSaveGetXMLDesc")
+		return "", makeNotImplementedError("virDomainManagedSaveGetXMLDesc")
 	}
 
 	var err C.virError
@@ -4710,7 +4710,7 @@ const (
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainSetLifecycleAction
 func (d *Domain) SetLifecycleAction(lifecycleType uint32, action uint32, flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 3009000 {
-		return GetNotImplementedError("virDomainSetLifecycleAction")
+		return makeNotImplementedError("virDomainSetLifecycleAction")
 	}
 
 	var err C.virError
@@ -4739,7 +4739,7 @@ func getDomainLaunchSecurityFieldInfo(params *DomainLaunchSecurityParameters) ma
 // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetLaunchSecurityInfo
 func (d *Domain) GetLaunchSecurityInfo(flags uint32) (*DomainLaunchSecurityParameters, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return nil, GetNotImplementedError("virDomainGetLaunchSecurityInfo")
+		return nil, makeNotImplementedError("virDomainGetLaunchSecurityInfo")
 	}
 
 	params := &DomainLaunchSecurityParameters{}
diff --git a/error.go b/error.go
index 37fefc1..1cfdf92 100644
--- a/error.go
+++ b/error.go
@@ -594,7 +594,7 @@ func makeError(err *C.virError) Error {
 	return ret
 }
 
-func GetNotImplementedError(apiname string) Error {
+func makeNotImplementedError(apiname string) Error {
 	return Error{
 		Code:    ERR_NO_SUPPORT,
 		Domain:  FROM_NONE,
diff --git a/lxc.go b/lxc.go
index 56ab28a..1578cab 100644
--- a/lxc.go
+++ b/lxc.go
@@ -141,7 +141,7 @@ func DomainLxcEnterSecurityLabel(model *NodeSecurityModel, label *SecurityLabel,
 
 func (d *Domain) DomainLxcEnterCGroup(flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 2000000 {
-		return GetNotImplementedError("virDomainLxcEnterCGroup")
+		return makeNotImplementedError("virDomainLxcEnterCGroup")
 	}
 
 	var err C.virError
diff --git a/network.go b/network.go
index d9ec9bf..99954aa 100644
--- a/network.go
+++ b/network.go
@@ -301,7 +301,7 @@ func (n *Network) Update(cmd NetworkUpdateCommand, section NetworkUpdateSection,
 // See also https://libvirt.org/html/libvirt-libvirt-network.html#virNetworkGetDHCPLeases
 func (n *Network) GetDHCPLeases() ([]NetworkDHCPLease, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002006 {
-		return []NetworkDHCPLease{}, GetNotImplementedError("virNetworkGetDHCPLeases")
+		return []NetworkDHCPLease{}, makeNotImplementedError("virNetworkGetDHCPLeases")
 	}
 	var cLeases *C.virNetworkDHCPLeasePtr
 	var err C.virError
diff --git a/network_events.go b/network_events.go
index 8ed16d9..2d9bddc 100644
--- a/network_events.go
+++ b/network_events.go
@@ -69,7 +69,7 @@ func networkEventLifecycleCallback(c C.virConnectPtr, n C.virNetworkPtr,
 func (c *Connect) NetworkEventLifecycleRegister(net *Network, callback NetworkEventLifecycleCallback) (int, error) {
 	goCallBackId := registerCallbackId(callback)
 	if C.LIBVIR_VERSION_NUMBER < 1002001 {
-		return 0, GetNotImplementedError("virConnectNetworkEventRegisterAny")
+		return 0, makeNotImplementedError("virConnectNetworkEventRegisterAny")
 	}
 
 	callbackPtr := unsafe.Pointer(C.networkEventLifecycleCallbackHelper)
@@ -91,7 +91,7 @@ func (c *Connect) NetworkEventLifecycleRegister(net *Network, callback NetworkEv
 
 func (c *Connect) NetworkEventDeregister(callbackId int) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002001 {
-		return GetNotImplementedError("virConnectNetworkEventDeregisterAny")
+		return makeNotImplementedError("virConnectNetworkEventDeregisterAny")
 	}
 	// Deregister the callback
 	var err C.virError
diff --git a/node_device_events.go b/node_device_events.go
index 632c94d..7920a42 100644
--- a/node_device_events.go
+++ b/node_device_events.go
@@ -85,7 +85,7 @@ func nodeDeviceEventGenericCallback(c C.virConnectPtr, d C.virNodeDevicePtr,
 
 func (c *Connect) NodeDeviceEventLifecycleRegister(device *NodeDevice, callback NodeDeviceEventLifecycleCallback) (int, error) {
 	if C.LIBVIR_VERSION_NUMBER < 2002000 {
-		return 0, GetNotImplementedError("virConnectNodeDeviceEventRegisterAny")
+		return 0, makeNotImplementedError("virConnectNodeDeviceEventRegisterAny")
 	}
 	goCallBackId := registerCallbackId(callback)
 
@@ -128,7 +128,7 @@ func (c *Connect) NodeDeviceEventUpdateRegister(device *NodeDevice, callback Nod
 
 func (c *Connect) NodeDeviceEventDeregister(callbackId int) error {
 	if C.LIBVIR_VERSION_NUMBER < 2002000 {
-		return GetNotImplementedError("virConnectNodeDeviceEventDeregisterAny")
+		return makeNotImplementedError("virConnectNodeDeviceEventDeregisterAny")
 	}
 	// Deregister the callback
 	var err C.virError
diff --git a/nwfilter_binding.go b/nwfilter_binding.go
index 5999d3e..e36c1de 100644
--- a/nwfilter_binding.go
+++ b/nwfilter_binding.go
@@ -43,7 +43,7 @@ type NWFilterBinding struct {
 // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterBindingFree
 func (f *NWFilterBinding) Free() error {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return GetNotImplementedError("virNWFilterBindingFree")
+		return makeNotImplementedError("virNWFilterBindingFree")
 	}
 	var err C.virError
 	ret := C.virNWFilterBindingFreeWrapper(f.ptr, &err)
@@ -56,7 +56,7 @@ func (f *NWFilterBinding) Free() error {
 // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterBindingRef
 func (c *NWFilterBinding) Ref() error {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return GetNotImplementedError("virNWFilterBindingRef")
+		return makeNotImplementedError("virNWFilterBindingRef")
 	}
 	var err C.virError
 	ret := C.virNWFilterBindingRefWrapper(c.ptr, &err)
@@ -69,7 +69,7 @@ func (c *NWFilterBinding) Ref() error {
 // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterBindingDelete
 func (f *NWFilterBinding) Delete() error {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return GetNotImplementedError("virNWFilterBindingDelete")
+		return makeNotImplementedError("virNWFilterBindingDelete")
 	}
 	var err C.virError
 	result := C.virNWFilterBindingDeleteWrapper(f.ptr, &err)
@@ -82,7 +82,7 @@ func (f *NWFilterBinding) Delete() error {
 // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterBindingGetPortDev
 func (f *NWFilterBinding) GetPortDev() (string, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return "", GetNotImplementedError("virNWFilterBindingGetPortDev")
+		return "", makeNotImplementedError("virNWFilterBindingGetPortDev")
 	}
 	var err C.virError
 	result := C.virNWFilterBindingGetPortDevWrapper(f.ptr, &err)
@@ -97,7 +97,7 @@ func (f *NWFilterBinding) GetPortDev() (string, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterBindingGetFilterName
 func (f *NWFilterBinding) GetFilterName() (string, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return "", GetNotImplementedError("virNWFilterBindingGetFilterName")
+		return "", makeNotImplementedError("virNWFilterBindingGetFilterName")
 	}
 	var err C.virError
 	result := C.virNWFilterBindingGetFilterNameWrapper(f.ptr, &err)
@@ -112,7 +112,7 @@ func (f *NWFilterBinding) GetFilterName() (string, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterBindingGetXMLDesc
 func (f *NWFilterBinding) GetXMLDesc(flags uint32) (string, error) {
 	if C.LIBVIR_VERSION_NUMBER < 4005000 {
-		return "", GetNotImplementedError("virNWFilterBindingGetXMLDesc")
+		return "", makeNotImplementedError("virNWFilterBindingGetXMLDesc")
 	}
 	var err C.virError
 	result := C.virNWFilterBindingGetXMLDescWrapper(f.ptr, C.uint(flags), &err)
diff --git a/qemu.go b/qemu.go
index dd4f258..a2f8507 100644
--- a/qemu.go
+++ b/qemu.go
@@ -151,7 +151,7 @@ func domainQemuMonitorEventCallback(c C.virConnectPtr, d C.virDomainPtr,
 
 func (c *Connect) DomainQemuMonitorEventRegister(dom *Domain, event string, callback DomainQemuMonitorEventCallback, flags DomainQemuMonitorEventFlags) (int, error) {
 	if C.LIBVIR_VERSION_NUMBER < 1002003 {
-		return 0, GetNotImplementedError("virConnectDomainQemuMonitorEventRegister")
+		return 0, makeNotImplementedError("virConnectDomainQemuMonitorEventRegister")
 	}
 
 	cEvent := C.CString(event)
@@ -176,7 +176,7 @@ func (c *Connect) DomainQemuMonitorEventRegister(dom *Domain, event string, call
 
 func (c *Connect) DomainQemuEventDeregister(callbackId int) error {
 	if C.LIBVIR_VERSION_NUMBER < 1002003 {
-		return GetNotImplementedError("virConnectDomainQemuMonitorEventDeregister")
+		return makeNotImplementedError("virConnectDomainQemuMonitorEventDeregister")
 	}
 
 	// Deregister the callback
diff --git a/secret_events.go b/secret_events.go
index 38605ba..d928e98 100644
--- a/secret_events.go
+++ b/secret_events.go
@@ -86,7 +86,7 @@ func secretEventGenericCallback(c C.virConnectPtr, n C.virSecretPtr,
 func (c *Connect) SecretEventLifecycleRegister(secret *Secret, callback SecretEventLifecycleCallback) (int, error) {
 	goCallBackId := registerCallbackId(callback)
 	if C.LIBVIR_VERSION_NUMBER < 3000000 {
-		return 0, GetNotImplementedError("virConnectSecretEventRegisterAny")
+		return 0, makeNotImplementedError("virConnectSecretEventRegisterAny")
 	}
 
 	callbackPtr := unsafe.Pointer(C.secretEventLifecycleCallbackHelper)
@@ -109,7 +109,7 @@ func (c *Connect) SecretEventLifecycleRegister(secret *Secret, callback SecretEv
 func (c *Connect) SecretEventValueChangedRegister(secret *Secret, callback SecretEventGenericCallback) (int, error) {
 	goCallBackId := registerCallbackId(callback)
 	if C.LIBVIR_VERSION_NUMBER < 3000000 {
-		return 0, GetNotImplementedError("virConnectSecretEventRegisterAny")
+		return 0, makeNotImplementedError("virConnectSecretEventRegisterAny")
 	}
 
 	callbackPtr := unsafe.Pointer(C.secretEventGenericCallbackHelper)
@@ -131,7 +131,7 @@ func (c *Connect) SecretEventValueChangedRegister(secret *Secret, callback Secre
 
 func (c *Connect) SecretEventDeregister(callbackId int) error {
 	if C.LIBVIR_VERSION_NUMBER < 3000000 {
-		return GetNotImplementedError("virConnectSecretEventDeregisterAny")
+		return makeNotImplementedError("virConnectSecretEventDeregisterAny")
 	}
 	// Deregister the callback
 	var err C.virError
diff --git a/storage_pool_events.go b/storage_pool_events.go
index 55c9f4e..fd1b997 100644
--- a/storage_pool_events.go
+++ b/storage_pool_events.go
@@ -85,7 +85,7 @@ func storagePoolEventGenericCallback(c C.virConnectPtr, s C.virStoragePoolPtr,
 
 func (c *Connect) StoragePoolEventLifecycleRegister(pool *StoragePool, callback StoragePoolEventLifecycleCallback) (int, error) {
 	if C.LIBVIR_VERSION_NUMBER < 2000000 {
-		return 0, GetNotImplementedError("virConnectStoragePoolEventRegisterAny")
+		return 0, makeNotImplementedError("virConnectStoragePoolEventRegisterAny")
 	}
 
 	goCallBackId := registerCallbackId(callback)
@@ -109,7 +109,7 @@ func (c *Connect) StoragePoolEventLifecycleRegister(pool *StoragePool, callback
 
 func (c *Connect) StoragePoolEventRefreshRegister(pool *StoragePool, callback StoragePoolEventGenericCallback) (int, error) {
 	if C.LIBVIR_VERSION_NUMBER < 2000000 {
-		return 0, GetNotImplementedError("virConnectStoragePoolEventRegisterAny")
+		return 0, makeNotImplementedError("virConnectStoragePoolEventRegisterAny")
 	}
 
 	goCallBackId := registerCallbackId(callback)
@@ -133,7 +133,7 @@ func (c *Connect) StoragePoolEventRefreshRegister(pool *StoragePool, callback St
 
 func (c *Connect) StoragePoolEventDeregister(callbackId int) error {
 	if C.LIBVIR_VERSION_NUMBER < 2000000 {
-		return GetNotImplementedError("virConnectStoragePoolEventDeregisterAny")
+		return makeNotImplementedError("virConnectStoragePoolEventDeregisterAny")
 	}
 
 	// Deregister the callback
diff --git a/storage_volume.go b/storage_volume.go
index 711c3c1..bb10813 100644
--- a/storage_volume.go
+++ b/storage_volume.go
@@ -169,7 +169,7 @@ func (v *StorageVol) GetInfo() (*StorageVolInfo, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-storage.html#virStorageVolGetInfoFlags
 func (v *StorageVol) GetInfoFlags(flags StorageVolInfoFlags) (*StorageVolInfo, error) {
 	if C.LIBVIR_VERSION_NUMBER < 3000000 {
-		return nil, GetNotImplementedError("virStorageVolGetInfoFlags")
+		return nil, makeNotImplementedError("virStorageVolGetInfoFlags")
 	}
 
 	var cinfo C.virStorageVolInfo
diff --git a/stream.go b/stream.go
index 515ae08..4010b11 100644
--- a/stream.go
+++ b/stream.go
@@ -121,7 +121,7 @@ func (v *Stream) Recv(p []byte) (int, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStreamRecvFlags
 func (v *Stream) RecvFlags(p []byte, flags StreamRecvFlagsValues) (int, error) {
 	if C.LIBVIR_VERSION_NUMBER < 3004000 {
-		return 0, GetNotImplementedError("virStreamRecvFlags")
+		return 0, makeNotImplementedError("virStreamRecvFlags")
 	}
 
 	var err C.virError
@@ -139,7 +139,7 @@ func (v *Stream) RecvFlags(p []byte, flags StreamRecvFlagsValues) (int, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStreamRecvHole
 func (v *Stream) RecvHole(flags uint) (int64, error) {
 	if C.LIBVIR_VERSION_NUMBER < 3004000 {
-		return 0, GetNotImplementedError("virStreamSparseRecvHole")
+		return 0, makeNotImplementedError("virStreamSparseRecvHole")
 	}
 
 	var len C.longlong
@@ -169,7 +169,7 @@ func (v *Stream) Send(p []byte) (int, error) {
 // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStreamSendHole
 func (v *Stream) SendHole(len int64, flags uint32) error {
 	if C.LIBVIR_VERSION_NUMBER < 3004000 {
-		return GetNotImplementedError("virStreamSendHole")
+		return makeNotImplementedError("virStreamSendHole")
 	}
 
 	var err C.virError
@@ -242,7 +242,7 @@ func (v *Stream) RecvAll(handler StreamSinkFunc) error {
 // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStreamSparseRecvAll
 func (v *Stream) SparseRecvAll(handler StreamSinkFunc, holeHandler StreamSinkHoleFunc) error {
 	if C.LIBVIR_VERSION_NUMBER < 3004000 {
-		return GetNotImplementedError("virStreamSparseSendAll")
+		return makeNotImplementedError("virStreamSparseSendAll")
 	}
 
 	callbackID := registerCallbackId(handler)
@@ -349,7 +349,7 @@ func (v *Stream) SendAll(handler StreamSourceFunc) error {
 // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStreamSparseSendAll
 func (v *Stream) SparseSendAll(handler StreamSourceFunc, holeHandler StreamSourceHoleFunc, skipHandler StreamSourceSkipFunc) error {
 	if C.LIBVIR_VERSION_NUMBER < 3004000 {
-		return GetNotImplementedError("virStreamSparseSendAll")
+		return makeNotImplementedError("virStreamSparseSendAll")
 	}
 
 	callbackID := registerCallbackId(handler)
-- 
2.17.1




More information about the libvir-list mailing list