[libvirt] [PATCH v2 2/2] tests: Update capabilities data for QEMU 2.12+ x86_64

[Erik Skultety]

On Tue, Jul 17, 2018 at 09:44:07AM +0200, Peter Krempa wrote:
> On Mon, Jul 16, 2018 at 16:57:13 +0200, Erik Skultety wrote:
> > The original capabilities didn't include a patched kernel for spectre
> > and meltdown, SPICE gl support and had xen support enabled which we
> > already have dropped.
> >
> > Signed-off-by: Erik Skultety <eskultet at redhat.com>
> > ---
> >  tests/domaincapsschemadata/qemu_2.12.0.x86_64.xml  |  37 +-
> >  .../caps_2.12.0.x86_64.replies                     | 539 +++++++++------------
> >  tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml  | 183 ++-----
>
> I'd prefer if you split these.
>
> Also it's worhy to note that the above removes testing of the AMD sev
> feature since it was hacked into reply data from an intel box which does
> not make sense. If we want to test that, we should get data from and
> actual AMD box.
>
> I'm not sure whether the change of cpu in the 2.12 caps will not change
> some test scope so posting it separately may give opportunity for some
> other feedback.
>
> >  .../qemucapabilitiesdata/caps_3.0.0.x86_64.replies | 219 ++++-----
> >  tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml   |  57 +--
>
> ACK to these changes split up into a separate patch. The previous
> version was generated by me so this is okay.
>
> My qemu did enable XEN which is correct to drop and my kernel is old
> enough to have spectre fixed so all the changes seem reasonable.

Alright, thanks, so I went ahead and pushed the previous patch with a patch
introducing only the 3.0.0 changes. I'll resend a separate patch for updating
2.12.0 as well as generating (probably only) 2.12+ on an AMD machine.

Erik