[libvirt] [jenkins-ci PATCH v2 04/12] lcitool: Add inventory handling

Katerina Koukiou kkoukiou at redhat.com
Tue Jul 17 17:32:53 UTC 2018


On Tue, Jul 17, 2018 at 02:51:47PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-07-17 at 11:57 +0200, Katerina Koukiou wrote:
> > On Thu, Jul 12, 2018 at 05:19:21PM +0200, Andrea Bolognani wrote:
> > > +import yaml
> > 
> > Since you have to install yaml to actually use it, I suggest at this
> > point to create a requirements.txt file for this script, so that users
> > don't have to go over the code to check the dependencies.
> 
> Neat idea.
> 
> If that's okay with you, I'd rather work on that as a follow-up
> enhancement though, because I need to do some reading on it and
> I'd rather not leave this series lingering for too long unless
> it's really necessary.

Sure, I am ok with that.

> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180717/ea7e8f50/attachment-0001.sig>


More information about the libvir-list mailing list