[libvirt] [PATCH v2 00/10] viriscsi: Couple of fixes

[John Ferlan]

On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> v2 of:
> 
> https://www.redhat.com/archives/libvir-list/2018-June/msg01861.html
> 
> diff to v1:
> - fixed misleading while() loop in 03/10
> - Introduced some tests
> - patch 06/10 is new, while writing the tests I've noticed that
>   errors from testIscsiadmCb were not propagated properly.
> 
> Patches 01,02,04 and 05 are ACKed already. Even though John
> suggested merging 04 and 05 together I haven't done that because
> I believe "iscsi --interface" and "iscsi --op nonpersistent" are
> orthogonal and even though we currently treat them as mutually
> exclusive (in storage backend) the util/viriscsi.c API should not
> suffer because of that.
> 
> Michal Privoznik (10):
>   virStorageBackendIQNFound: Fix ret value assignment
>   virStorageBackendIQNFound: Rename out label
>   virStorageBackendIQNFound: Rework iscsiadm output parsing
>   virISCSIScanTargets: Honour iSCSI interface
>   virISCSIScanTargets: Allow making targets persistent
>   virCommandWait: Propagate dryRunCallback return value properly
>   viriscsitest: Test virISCSIConnectionLogin
>   viriscsitest: Move testSessionInfo struct
>   viriscsitest: Introduce testIscsiadmCbData struct
>   viriscsitest: Extend virISCSIConnectionLogin test
> 
>  src/storage/storage_backend_iscsi.c |   5 +-
>  src/util/vircommand.c               |   2 +
>  src/util/viriscsi.c                 | 196 ++++++++++++++++++++++++------------
>  src/util/viriscsi.h                 |   2 +
>  tests/viriscsitest.c                | 145 ++++++++++++++++++++++++--
>  5 files changed, 272 insertions(+), 78 deletions(-)
> 

I think a release note to indicate fixing some iSCSI Initiator IQN
issues would be appropriate...

John