[libvirt] [dbus PATCH] tests: Explicitly spawn a session libvirt-dbus instance

Katerina Koukiou kkoukiou at redhat.com
Wed Jul 18 10:36:54 UTC 2018


On Wed, Jul 18, 2018 at 11:50:33AM +0200, Andrea Bolognani wrote:
> Tests are performed using the session D-Bus instance, so we
> should launch libvirt-dbus in session mode as well.
> 
> This was working fine when running the tests as a regular
> user, because in that case libvirt-dbus would default to
> session mode, but fail when running them as root because
> libvirt-dbus would run in system mode and consequently not
> show up on the session bus.
> 
> Of course building and runnning the test suite as root is
> a pretty bad idea in general, but a lot of distributions
> run at least part of their package build steps with pretend
> root privileges (eg. fakeroot), so we have to make sure it
> works in that scenario too.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  tests/libvirttest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Katerina Koukiou <kkoukiou at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180718/6379a755/attachment-0001.sig>


More information about the libvir-list mailing list