[libvirt] [PATCH 03/10] qemu: hotplug: Don't format NULL in %s in qemuHotplugPrepareDiskAccess

Ján Tomko jtomko at redhat.com
Wed Jul 18 14:22:30 UTC 2018


On Tue, Jul 17, 2018 at 02:14:23PM +0200, Peter Krempa wrote:
>The warning messages which include the disk source could potentially
>format NULL using %s as virDomainDiskGetSource may return NULL for e.g.
>NBD disks. As most of the APIs are NOOP for remote disks the usage of
>the source string only should be fine for now.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_hotplug.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180718/60e5290e/attachment-0001.sig>


More information about the libvir-list mailing list