[libvirt] [PATCH] utils: storage: Add copying of PR definition to virStorageSource

Ján Tomko jtomko at redhat.com
Fri Jul 20 11:46:36 UTC 2018


On Tue, Jul 17, 2018 at 04:03:49PM +0200, Peter Krempa wrote:
>Despite the warning that virStorageSourceCopy needs to be populated on
>additions to the structure commit 687730540e4 neglected to implement the
>copy function.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/util/virstoragefile.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Also not copied:
    bool authInherited;
    bool encryptionInherited;
    bool nocow;
    bool sparse;
and all the properties from the last section (starting at 'iomode')

It would be nice to mention the properties that do not need to be copied
and copy them in the same order they are declared in.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180720/03ea55d1/attachment-0001.sig>


More information about the libvir-list mailing list