[libvirt] [jenkins-ci PATCH] lcitool: Update OS when building Docker images

[Andrea Bolognani]

The last build of the Fedora Rawhide Docker image failed
with

  Transaction check error:
    file /usr/lib64/libgdbm_compat.so.4.0.0 from install
    of gdbm-libs-1:1.16-1.fc29.x86_64 conflicts with file
    from package gdbm-1:1.14.1-3.fc28.x86_64

caused by the gdbm package having recently been split.

Especially with fast-moving distribution such as Fedora
Rawhide and Debian Sid, we can't rely on the base OS not
changing over time, so merely installing the packages we
need on top of that is not enough.

Additionally, updating the OS brings the Docker images
closer to the guests running on CentOS CI, which are
updated daily.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 guests/lcitool | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guests/lcitool b/guests/lcitool
index 22b08dd..33c1afe 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -478,13 +478,15 @@ class Application:
         if package_format == "deb":
             sys.stdout.write(textwrap.dedent("""
                 RUN apt-get update && \\
+                    apt-get dist-upgrade -y && \\
                     apt-get install -y ${PACKAGES} && \\
                     apt-get autoremove -y && \\
                     apt-get autoclean -y
             """))
         elif package_format == "rpm":
             sys.stdout.write(textwrap.dedent("""
-                RUN yum install -y ${PACKAGES} && \\
+                RUN yum update -y && \\
+                    yum install -y ${PACKAGES} && \\
                     yum autoremove -y && \\
                     yum clean all -y
             """))
-- 
2.17.1