[libvirt] [PATCH v2 RESEND 04/12] qemu: Enable PCI multi bus for S390 guests

Ján Tomko jtomko at redhat.com
Mon Jul 23 11:36:19 UTC 2018


On Tue, Jul 10, 2018 at 04:02:18PM +0800, Yi Min Zhao wrote:
>QEMU on s390 supports PCI multibus since forever. But zPCI, as extension
>of PCI device on s390, is the significant capability. Only when zPCI
>capability is existing, we consider QEMU supports PCI multibus properly.
>So let enable PCI multibus only if zPCI is supported.
>

This comment is now outdated, since we assume multibus in all cases
(even though it only makes sense with ZPCI)

Jano

>Signed-off-by: Yi Min Zhao <zyimin at linux.ibm.com>
>Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>Reviewed-by: Stefan Zimmermann <stzi at linux.ibm.com>
>Reviewed-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
>---
> src/qemu/qemu_capabilities.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>index 07f58fd014..7cba7eecdc 100644
>--- a/src/qemu/qemu_capabilities.c
>+++ b/src/qemu/qemu_capabilities.c
>@@ -1760,6 +1760,10 @@ bool virQEMUCapsHasPCIMultiBus(virQEMUCapsPtr qemuCaps,
>         return false;
>     }
>
>+    /* S390 supports PCI-multibus. */
>+    if (ARCH_IS_S390(def->os.arch))
>+        return true;
>+
>     /* If 'virt' supports PCI, it supports multibus.
>      * No extra conditions here for simplicity.
>      */
>-- 
>Yi Min
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180723/e92ad17d/attachment-0001.sig>


More information about the libvir-list mailing list