[libvirt] [PATCH 04/24] tests: qemuxml2argv: Remove tests obsoleted by assuming support for '-device'

Ján Tomko jtomko at redhat.com
Mon Jul 23 11:50:58 UTC 2018


On Thu, Jul 19, 2018 at 05:50:56PM +0200, Peter Krempa wrote:
>Few disk tests were testing support for pure -drive command line
>generation for disks now that we assume it for all qemu versions the
>cases are obsolete.
>
>Replacements:
>disk-readonly-no-device -> disk-readonly-disk
>disk-floppy-tray-no-device -> disk-floppy-tray
>disk-cdrom-tray-no-device -> disk-cdrom-tray
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> .../disk-cdrom-tray-no-device-cap.args             | 29 -----------------
> .../disk-cdrom-tray-no-device-cap.xml              | 32 -------------------
> .../disk-floppy-tray-no-device-cap.args            | 31 ------------------
> .../disk-floppy-tray-no-device-cap.xml             | 37 ----------------------
> .../qemuxml2argvdata/disk-readonly-no-device.args  | 30 ------------------
> tests/qemuxml2argvdata/disk-readonly-no-device.xml | 32 -------------------
> tests/qemuxml2argvtest.c                           |  3 --
> 7 files changed, 194 deletions(-)
> delete mode 100644 tests/qemuxml2argvdata/disk-cdrom-tray-no-device-cap.args
> delete mode 100644 tests/qemuxml2argvdata/disk-cdrom-tray-no-device-cap.xml
> delete mode 100644 tests/qemuxml2argvdata/disk-floppy-tray-no-device-cap.args
> delete mode 100644 tests/qemuxml2argvdata/disk-floppy-tray-no-device-cap.xml
> delete mode 100644 tests/qemuxml2argvdata/disk-readonly-no-device.args
> delete mode 100644 tests/qemuxml2argvdata/disk-readonly-no-device.xml
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180723/26e9841e/attachment-0001.sig>


More information about the libvir-list mailing list