[libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

[Michal Privoznik]

On 07/24/2018 04:08 PM, John Ferlan wrote:
> 
>  <snip/>> Reading something like:
> 
>  /* mocking real environment output is not feasible for [creating |
> updating | logging into], example of real environment is:
> 
> xxx
> 
>  */
> 
> I believe is better - it's not difficult to add, but I'm at the point of
> not caring right now because this truly has gone on too long.
> 
> For the code/logic:
> 
> Reviewed-by: John Ferlan <jferlan at redhat.com>
> 
> Do whatever you want for the comments. I disagree that "nada" or "no
> output" is good enough, but it's not worth holding this up.

Thanks. I'll add the real output into comments as you're suggesting.

Michal