[libvirt] [PATCH 2/9] util: Refactor virResctrlGetInfo in virresctrl

John Ferlan jferlan at redhat.com
Tue Jul 24 22:02:23 UTC 2018



On 07/18/2018 03:57 AM, bing.niu at intel.com wrote:
> From: Bing Niu <bing.niu at intel.com>
> 
> Separate resctrl common information parts from CAT specific parts,
> so that common information parts can be reused among different
> resource allocation technologies.
> 
> Signed-off-by: Bing Niu <bing.niu at intel.com>
> ---
>  src/util/virresctrl.c | 31 ++++++++++++++++++++++---------
>  1 file changed, 22 insertions(+), 9 deletions(-)
> 

I'm assuming you are coordinating with the [RFC PATCHv2 00/10] x86 RDT
Cache Monitoring Technology (CMT)​ that's on list as well. I don't have
the cycles to do any compare/contrast between the two...

> diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
> index 6d69c8d..98e7296 100644
> --- a/src/util/virresctrl.c
> +++ b/src/util/virresctrl.c
> @@ -318,9 +318,8 @@ virResctrlUnlock(int fd)
>  
>  /* virResctrlInfo-related definitions */
>  static int
> -virResctrlGetInfo(virResctrlInfoPtr resctrl)
> +virResctrlGetCacheInfo(virResctrlInfoPtr resctrl, DIR *dirp)

One argument per line... I can fix before pushing though.

Reviewed-by: John Ferlan <jferlan at redhat.com>

John




More information about the libvir-list mailing list