[libvirt] [PATCH v1 26/40] util: scsi: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

Erik Skultety eskultet at redhat.com
Wed Jul 25 09:39:34 UTC 2018


On Sat, Jul 21, 2018 at 05:36:58PM +0530, Sukrit Bhatnagar wrote:
> Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
> src/util/viralloc.h, define a new wrapper around an existing
> cleanup function which will be called when a variable declared
> with VIR_AUTOPTR macro goes out of scope. Also, drop the redundant
> viralloc.h include, since that has moved from the source module into
> the header.
>
> When variables of type virSCSIDevicePtr and virUsedByInfoPtr
> are declared using VIR_AUTOPTR, the functions virSCSIDeviceFree
> and virSCSIDeviceUsedByInfoFree, respectively, will be run
> automatically on them when they go out of scope.
>
> This commit also adds an intermediate typedef for virCgroup type
> for use with the cleanup macros by renaming the struct in
> src/util/vircgrouppriv.h from virCgroup to _virCgroup.

You need to tweak ^this copy-paste to match the module ;).

Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list