[libvirt] [dbus PATCH 1/2] tests: {interface, node_device}_create should be used as setup fixtures

Ján Tomko jtomko at redhat.com
Thu Jul 26 12:33:52 UTC 2018


On Thu, Jul 26, 2018 at 02:09:57PM +0200, Katerina Koukiou wrote:
>* node_device_create was a fixture but we were calling it as normal function,
>thus it got triggered twice.
>* interface_create was not a fixture.
>
>This patch makes sure that the setup work these two functions are doing, will
>run before the actual test call phase.
>
>Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
>---
> tests/libvirttest.py    |  1 +
> tests/test_connect.py   |  9 +++++----
> tests/test_interface.py | 22 ++++++++++++----------
> tests/test_nodedev.py   | 16 ++++++++--------
> 4 files changed, 26 insertions(+), 22 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180726/56684155/attachment-0001.sig>


More information about the libvir-list mailing list