[libvirt] [dbus PATCH 2/2] tests: fix all coding style issues to comply with pep8

[Ján Tomko]

On Thu, Jul 26, 2018 at 02:09:58PM +0200, Katerina Koukiou wrote:

Is there nothing that could be said here in the commit message?

Also, it might be a good time to introduce a 'syntax-check' target
to Makefile, to make sure these won't get merged again.

>Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
>---
> tests/test_connect.py   |  2 +-
> tests/test_domain.py    |  5 +++--
> tests/test_interface.py | 11 ++++++-----
> tests/test_network.py   |  8 ++++----
> tests/test_storage.py   |  1 +
> 5 files changed, 15 insertions(+), 12 deletions(-)
>
>diff --git a/tests/test_domain.py b/tests/test_domain.py
>index b9a6d33..96b282c 100755
>--- a/tests/test_domain.py
>+++ b/tests/test_domain.py
>@@ -5,6 +5,7 @@ import libvirttest
>
> DBUS_EXCEPTION_MISSING_FUNCTION = 'this function is not supported by the connection driver'
>
>+
> class TestDomain(libvirttest.BaseTestClass):
>     def test_api(self):
>         obj, domain = self.get_test_domain()
>@@ -153,8 +154,8 @@ class TestDomain(libvirttest.BaseTestClass):
>     def test_domain_vcpu_pin_info(self):
>         obj, domain = self.get_test_domain()
>         pinInfo_expected = [
>-                [ True, True, True, True, True, True, True, True ],
>-                [ True, True, True, True, True, True, True, True ]
>+                [True, True, True, True, True, True, True, True],
>+                [True, True, True, True, True, True, True, True]

The 'flake8 --ignore=E501' command you proposed months ago [0] still
shows some issues, including:

./tests/test_domain.py:157:17: E126 continuation line over-indented for hanging indent
                [True, True, True, True, True, True, True, True],
                ^

Jano

[0] https://www.redhat.com/archives/libvir-list/2018-March/msg01368.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180726/34dfcb8e/attachment-0001.sig>