[libvirt] [PATCH v2 18/41] util: hook: use VIR_AUTOPTR for aggregate types

Sukrit Bhatnagar skrtbhtngr at gmail.com
Tue Jul 24 15:52:19 UTC 2018


By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.

Signed-off-by: Sukrit Bhatnagar <skrtbhtngr at gmail.com>
Reviewed-by: Erik Skultety <eskultet at redhat.com>
---
 src/util/virhook.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/util/virhook.c b/src/util/virhook.c
index 4673655..993f06d 100644
--- a/src/util/virhook.c
+++ b/src/util/virhook.c
@@ -232,7 +232,7 @@ virHookCall(int driver,
 {
     int ret;
     VIR_AUTOFREE(char *) path = NULL;
-    virCommandPtr cmd;
+    VIR_AUTOPTR(virCommand) cmd = NULL;
     const char *drvstr;
     const char *opstr;
     const char *subopstr;
@@ -314,7 +314,5 @@ virHookCall(int driver,
                        virGetLastErrorMessage());
     }
 
-    virCommandFree(cmd);
-
     return ret;
 }
-- 
1.8.3.1




More information about the libvir-list mailing list