[libvirt] [PATCH v2 37/41] util: iscsi: use VIR_AUTOPTR for aggregate types

Erik Skultety eskultet at redhat.com
Fri Jul 27 14:32:20 UTC 2018


On Tue, Jul 24, 2018 at 09:22:38PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of our cleanup sections.
>
> Signed-off-by: Sukrit Bhatnagar <skrtbhtngr at gmail.com>
> Reviewed-by: Erik Skultety <eskultet at redhat.com>

For the time being, I'm going to retract my ^RB (the same goes for the previous
patch).

There are some merge conflicts while applying this and the previous patch
(there's been a work on this module recently), so you should resolve them a
sent as part of the next batch.

Erik




More information about the libvir-list mailing list