[libvirt] [PATCH v2 16/17] conf: Add return value check to virResctrlAllocForeachCache

bing.niu at intel.com bing.niu at intel.com
Sat Jul 28 05:48:40 UTC 2018


From: Bing Niu <bing.niu at intel.com>

Add return value check to virResctrlAllocForeachCache in
virDomainCachetuneDefFormat. The virResctrlAllocForeachCache dose have
return value, so need check return value to make sure function execute
without error.

Signed-off-by: Bing Niu <bing.niu at intel.com>
---
 src/conf/domain_conf.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 9acdea7..3b68f53 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -27198,10 +27198,10 @@ virDomainCachetuneDefFormat(virBufferPtr buf,
     int ret = -1;
 
     virBufferSetChildIndent(&childrenBuf, buf);
-    virResctrlAllocForeachCache(resctrl->alloc,
-                                virDomainCachetuneDefFormatHelper,
-                                &childrenBuf);
-
+    if (virResctrlAllocForeachCache(resctrl->alloc,
+                                    virDomainCachetuneDefFormatHelper,
+                                    &childrenBuf) < 0)
+        goto cleanup;
 
     if (virBufferCheckError(&childrenBuf) < 0)
         goto cleanup;
-- 
2.7.4




More information about the libvir-list mailing list