[libvirt] [PATCH 3/3] conf: rename Match functions

Anya Harter aharter at redhat.com
Mon Jul 30 14:07:53 UTC 2018


to be the vir prefix and interface name followed by ObjMatch

    ex. for virNetworkObjListExport, the match function is named
            virNetworkObjMatch

Signed-off-by: Anya Harter <aharter at redhat.com>
---
 src/conf/virnetworkobj.c    | 6 +++---
 src/conf/virnodedeviceobj.c | 4 ++--
 src/conf/virsecretobj.c     | 4 ++--
 src/conf/virstorageobj.c    | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c
index c8939460a3..48d4ffecce 100644
--- a/src/conf/virnetworkobj.c
+++ b/src/conf/virnetworkobj.c
@@ -1272,7 +1272,7 @@ virNetworkObjUpdate(virNetworkObjPtr obj,
 
 #define MATCH(FLAG) (flags & (FLAG))
 static bool
-virNetworkMatch(virNetworkObjPtr obj,
+virNetworkObjMatch(virNetworkObjPtr obj,
                 unsigned int flags)
 {
     /* filter by active state */
@@ -1331,7 +1331,7 @@ virNetworkObjListExportCallback(void *payload,
         !data->filter(data->conn, obj->def))
         goto cleanup;
 
-    if (!virNetworkMatch(obj, data->flags))
+    if (!virNetworkObjMatch(obj, data->flags))
         goto cleanup;
 
     if (!data->nets) {
@@ -1547,7 +1547,7 @@ virNetworkObjListPruneHelper(const void *payload,
     int want = 0;
 
     virObjectLock(obj);
-    want = virNetworkMatch(obj, data->flags);
+    want = virNetworkObjMatch(obj, data->flags);
     virObjectUnlock(obj);
     return want;
 }
diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c
index 6c04caf6ab..f6d940905c 100644
--- a/src/conf/virnodedeviceobj.c
+++ b/src/conf/virnodedeviceobj.c
@@ -804,7 +804,7 @@ virNodeDeviceObjListGetNames(virNodeDeviceObjListPtr devs,
 #define MATCH(FLAG) ((flags & (VIR_CONNECT_LIST_NODE_DEVICES_CAP_ ## FLAG)) && \
                      virNodeDeviceObjHasCap(obj, VIR_NODE_DEV_CAP_ ## FLAG))
 static bool
-virNodeDeviceMatch(virNodeDeviceObjPtr obj,
+virNodeDeviceObjMatch(virNodeDeviceObjPtr obj,
                    unsigned int flags)
 {
     /* Refresh the capabilities first, e.g. due to a driver change */
@@ -864,7 +864,7 @@ virNodeDeviceObjListExportCallback(void *payload,
     def = obj->def;
 
     if ((!data->filter || data->filter(data->conn, def)) &&
-        virNodeDeviceMatch(obj, data->flags)) {
+        virNodeDeviceObjMatch(obj, data->flags)) {
         if (data->devices) {
             if (!(device = virGetNodeDevice(data->conn, def->name)) ||
                 VIR_STRDUP(device->parentName, def->parent) < 0) {
diff --git a/src/conf/virsecretobj.c b/src/conf/virsecretobj.c
index ba360810f4..f1a22c5d6c 100644
--- a/src/conf/virsecretobj.c
+++ b/src/conf/virsecretobj.c
@@ -500,7 +500,7 @@ virSecretObjListNumOfSecrets(virSecretObjListPtr secrets,
 
 #define MATCH(FLAG) (flags & (FLAG))
 static bool
-virSecretObjMatchFlags(virSecretObjPtr obj,
+virSecretObjMatch(virSecretObjPtr obj,
                        unsigned int flags)
 {
     virSecretDefPtr def = obj->def;
@@ -554,7 +554,7 @@ virSecretObjListExportCallback(void *payload,
     if (data->filter && !data->filter(data->conn, def))
         goto cleanup;
 
-    if (!virSecretObjMatchFlags(obj, data->flags))
+    if (!virSecretObjMatch(obj, data->flags))
         goto cleanup;
 
     if (!data->secrets) {
diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c
index 6b8a0fa58d..23a66e8dff 100644
--- a/src/conf/virstorageobj.c
+++ b/src/conf/virstorageobj.c
@@ -1906,7 +1906,7 @@ virStoragePoolObjSourceFindDuplicate(virConnectPtr conn,
 
 #define MATCH(FLAG) (flags & (FLAG))
 static bool
-virStoragePoolMatch(virStoragePoolObjPtr obj,
+virStoragePoolObjMatch(virStoragePoolObjPtr obj,
                     unsigned int flags)
 {
     /* filter by active state */
@@ -1999,7 +1999,7 @@ virStoragePoolObjListExportCallback(void *payload,
     if (data->filter && !data->filter(data->conn, obj->def))
         goto cleanup;
 
-    if (!virStoragePoolMatch(obj, data->flags))
+    if (!virStoragePoolObjMatch(obj, data->flags))
         goto cleanup;
 
     if (data->pools) {
-- 
2.17.1




More information about the libvir-list mailing list