[libvirt] [PATCH] qemu: qemuDomainChangeNet: don't overwrite device info when pci addr is missing

[Ján Tomko]

On Tue, Jul 31, 2018 at 05:32:51PM +0200, Katerina Koukiou wrote:
>On Tue, Jul 31, 2018 at 05:15:51PM +0200, Ján Tomko wrote:
>> On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote:
>> > When trying to update an interface's rom settings with an device XML
>> > that is missing the PCI addr element, all new rom settings where not applied.
>> >
>> > https://bugzilla.redhat.com/show_bug.cgi?id=1599513
>> >
>> > Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
>> > ---
>> > Not sure why we chose to overwrite the whole info before though, I hope
>> > that this doesn't cause side problems.
>> >
>>
>> It allows the user to omit parts of the XML that do not need changing.
>
>But this happens now only if PCI addr is missing.
>
>>
>> By dropping the virDomainDeviceInfoCopy call, we start validating the
>> attributes that weren't provided in the XML.
>>
>> If we want to keep this convenience functionality, we should also autofill
>> other fields of virDomainDeviceInfo which weren't provided in the XML.
>
>The functionality right now is that only if PCI addr is missing, then
>autofilling happens, by overwriting all other passed params. I don't
>really consider it a convenience functionality, more of confusing.

It is both confusing and convenient.

>I think overwritting the specific object that is missing is more
>correct. What do you think?
>

Yes. I'm afraid we cannot get rid of the 'change with incomplete XML'
behavior after all the years.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180731/88bc6ddf/attachment-0001.sig>