[libvirt] [PATCH] domain_nwfilter: Return early if net has no name in virDomainConfNWFilterTeardownImpl

Erik Skultety eskultet at redhat.com
Mon Jul 9 12:56:08 UTC 2018


On Mon, Jul 09, 2018 at 02:40:04PM +0200, Michal Privoznik wrote:
> This function is called from various clean up paths (e.g.
> from qemuBuildInterfaceCommandLine). However, depending on the
> stage the interface creation process failed at, net->ifname might
> still be not filled in when control jumps to cleanup label. If
> that is the case return early (avoiding useless error message
> produced in virNWFilterBindingLookupByPortDev) as there is no
> NWFilter to tear down anyway.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list